Closed (fixed)
Project:
Review
Version:
master
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
7 Dec 2005 at 01:10 UTC
Updated:
2 Jan 2006 at 04:40 UTC
Jump to comment: Most recent file
It seems like most of the meat of this module has been outsourced to other modules:
* Word count is done in core now
* Weblinks has been replaced by links module which uses the form_alter to insert it's elements
So, I went through and:
* Converted to forms API
* Changed "s to 's when possible
* Fixed changed hooks and menu locations
* Moved formatting to themes
* Created some new star graphics
It's pretty much a rewrite so I'll attach both the complete module, and a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | review.patch | 23.05 KB | drewish |
| #2 | star_on.gif | 707 bytes | drewish |
| #1 | star_off.gif | 698 bytes | drewish |
| review.module | 10.37 KB | drewish |
Comments
Comment #1
drewish commentedComment #2
drewish commentedComment #3
drewish commentedComment #4
Bèr Kessels commentedThe weblinks stuff breaks the default links stuff (http://drupal.org/node/24719) you could best read the docs in that tarball, as to how to use links. Its not hard at all, in fact, it will make review a *lot* simpler too.
For the rest, i like you changes.
Comment #5
Bèr Kessels commentedBah, µI must have been asleep whne reading taht patch.
It does remove thelink management. Sorry.
Comment #6
drewish commentedNo, you were right, I hadn't removed all the weblinks stuff. I'll roll up another patch when I get a minute.
Comment #7
drewish commentedCommited to HEAD.
Comment #8
(not verified) commented