Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Logged as admin, I tried to add a reservation (I don't even know if it is the right way to do since I didn't see any manual).
There's no form to inform on dates to book... So I can't proceed to the reservation.
Not logged (I gave rights for this), it's even worse : there's no more ressource to book, and still no date selector.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 402302.patch | 757 bytes | stella |
| #4 | merci.install.patch | 4.1 KB | darrick |
| issue.png | 33.13 KB | tahiticlic |
Comments
Comment #1
kreynen commentedThere is definitely something wrong here. It looks like your MERCI Reservation is missing it's Date API fields in CCK. Did you try to update this from a previous version of MERCI?
I would disable the module and uninstall it so all of the tables MERCI creates are dropped and reinstall it. We moved from using a field named just date to merci_date at some point. If you already have a field called date and tried one of the older versions of MERCI that might explain this.
You should also try MERCI's Import to set up a few demo Resources and Buckets.
Hopefully this will resolve your issue.
Comment #2
tahiticlic commentedHi,
no I didn't try to update a previous version, this is a new install.
I will try to install on a fresh Drupal install, just to see how it works (I should have done this before...).
I'll give a try to MERCI's import and will let you know the result.
[EDIT]
I've just re-installed MERCI, and for this part of date/time form, it seems to work.
Bad point is that the uninstall process erased the content type which used MERCI...
However, there are other errors/warnings which shouldn't be there, I'll post specific issues if it doesn't work with a Drupal fresh install.
[/EDIT]
Comment #3
tahiticlic commentedWell, on a fresh install, with only Merci and Admin menu activated, date/time forms are not visible.
And on the previous install, I noticed that warning came from db query which didn't integrate the prefix I mentioned in drupal install...
Well, I guess it is not stable yet, i'll come back later to follow the development.
Comment #4
darrick commentedIf merci is installed without the date module already installed then the cck date field doesn't get created. I've attached a patch to fix this by moving the creation of field_merci_date from hook_install to hook_enable (after checking if the cck field exists.)
Hope this helps.
Comment #5
kreynen commentedComment #6
tahiticlic commentedHi,
great, it works fine for the form part with the patch.
I'm a bit surprised to be alone to report the warning problem, anyway I found the problem :
in merci.module, lines 1570 and 1619, there are query chains which are made using "{$table}", the problem is that when it is parsed by php, brackets are removed... so there's no prefix added. If you don't use a prefix, you cannot see the problem.
I corrected it by adding one pair of brackets, leading to "{{$table}}".
I didn't look further to find another such missing brackets, at least these two lines need a fix.
Is there a forum to ask questions about Merci usage? For instance, I was wondering if there could be a "book it" link directly on a reservable object node, because I find the "Create a reservation" way not enough user friendly.
Comment #8
david.lukac commentedI have the same issue with no seeing Date form but in Open Atrium installation. We tried both stable and dev version with the same result. Datetime field is present in the content type.
Comment #9
kreynen commentedDo you have the issue when using MERCI on a standard Drupal install?
Comment #10
david.lukac commentedNop, it's working fine on plain Drupal installation. But I have no idea what could cause the issue on Open Atrium. I have posted the issue also to OA groups, maybe somebody got it running. If yes I sure let you know here. Haven't you guys tried it ?
It would be great if the module was running also under OA. I think it would have great use for resource reservation/booking in enterprise environment. E.g. now we would like to use it for car booking for our customer.
Comment #11
stella commentedThis is happening for me too, now that I upgraded from the 6.x-1.0 version to the latest dev version from today. I then tried disabling and uninstalling the module, but the date fields still don't appear. The date, date api, date timezone and date tools modules were all enabled by the way.
By the way I didn't really expect the module to delete all my content when the module was uninstalled, it shouldn't really to be honest. Luckily I still had my import files.
Comment #12
stella commentedI fixed the problem by changing the weight of the merci modules in the system table to be higher than that of the date modules. The attached patch does it in hook_install() now. The only thing I'm unsure of is if the same thing needs to be done in the other merci sub-modules, so each of those has the same or higher weight than the 'merci' module.
Comment #13
kreynen commentedcommitted to dev release
Comment #14
darrick commentedThis current fix is not maintainable. With the recent additions of the $member_cost_field and $commerical_cost_field merci now also depends on the number module. So for this to work you would have to also set the merci weight higher then the number module as well as the date module.
My first patch moved the creation of all fields from hook_install to hook_module. I've done the same for all the other OM modules. I basically copied the same functionality I've seen in other modules (i.e. date_api).
I went ahead and commited the change today, as the added $member_cost_field and $commerical_cost_field were not being created on upgrade anyway. I've added a merci_update_5 function to create those fields on update. So existing installations will be upgraded properly and new installations without the enabled number and date modules will also install correctly.
Comment #15
darrick commented