Posted by bangpound on March 15, 2009 at 5:00pm
| Project: | Views |
| Version: | 6.x-2.x-dev |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | export, Version Control |
Issue Summary
This patch does only two things:
1. On exported views, it inserts a PHP comment to better distinguish views from each other.
2. Sorts exported views alphabetically by view name.
The combination of these two things makes exported views more friendly with SCM.
| Attachment | Size |
|---|---|
| views2-bulk-export-scm-friendly.patch | 1.45 KB |
Comments
#1
I'm all for this. I'd actually added code to get the sort order working locally and found this when I went to post an issue. As bangpound says this is really helpful when exporting views to track them in source control. Without it the view order changes when you edit a view making the exports much harder to read.
Test it it on exports and it works fine. Code also looks good.
#2
actually this moves the sorting from the actual time of export up to where we build the list of exportables. this sorts the table the same as the exported code--which also syncs the view order up with the admin/build/views page.
#3
drewish: awesome. thanks for the improvement! i am running on your patch now.
RTBC RTBC RTBC.
#4
I am so totally in favor of this patch it's not even funny, despite having done nothing to help it along in the slightest. :-)
#5
On IRC merlin had mentioned fixing the case of Views in the comment. Done.
#6
Committed! Thanks!
#7
Automatically closed -- issue fixed for 2 weeks with no activity.