make the module themeable

shua.adi - March 15, 2009 - 18:03
Project:Clickpath
Version:6.x-1.1
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs work
Description

made the module themeable with hook_theme and overrideable function which gets the block content as an array.

AttachmentSize
patch_theme.txt2.09 KB

#1

shua.adi - March 15, 2009 - 18:07
Status:active» needs review

#2

coltrane - March 16, 2009 - 14:54
Status:needs review» needs work

Patch contains the "consider list" code from #402682: "consider" list please reroll and I'll review, I'm in favor of this feature.

#3

shua.adi - March 17, 2009 - 11:05
AttachmentSize
patch_theme.txt 1.95 KB

#4

coltrane - March 17, 2009 - 15:12
Status:needs work» needs review

#5

coltrane - March 21, 2009 - 19:01
Status:needs review» needs work

#3 patch contains a variable_get('clickpath_block_list_as_path'). This variable isn't set in the patch and doesn't exist in the module. Was this patch rolled from a more modified version of clickpath?

#6

shua.adi - March 24, 2009 - 14:13

Hi,
yes sorry I missed it. i split the original into two issues. the variable was taken from the form.
I'll send it soon with the form changing inside.

Adi.

 
 

Drupal is a registered trademark of Dries Buytaert.