admin.inc files not included in pot file

Dave Reid - March 15, 2009 - 19:08
Project:Translation template extractor
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

I have a module directory structure like:

/sites/all/modules
  /path_redirect
    /genereate
      path_redirect_generate.info
      path_redirect_generate.module
    path_redirect.admin.inc
    path_redirect.info
    path_redirect.install
    path_redirect.module
    path_redirect.test

With Extract from all in directory "sites/all/modules/path_redirect", the path_redirect.admin.inc file is included in the pot file (expected).

With Extract from path_redirect (in the fieldset), path_redirect.admin.inc is not included in the pot file (unexpected).

With Extract from path_redirect_generate in the sites/all/modules/path_redirect/generate directory (in the fieldset), path_redirect.admin.inc is not included in the pot file (expected).

AttachmentSize
screenshot_003.png24.01 KB

#1

Dave Reid - March 15, 2009 - 19:10

And I'm using the very latest 6.x-2.x CVS branch.

#2

Gábor Hojtsy - March 16, 2009 - 11:41

Well, potx is trying to look for path_redirect.{any of the known extensions}, and .admin.inc is not a known extension. The file lookup pattern probably needs to be changed to {modulename}{.optional whatever}.{any of the known extensions}.

#3

Gábor Hojtsy - March 16, 2009 - 15:37

Try this patch.

AttachmentSize
filename-suffix.patch 1.12 KB

#4

Gábor Hojtsy - March 16, 2009 - 15:39

Duh, of course that was untested, so a typo was in there. Try this instead.

AttachmentSize
filename-suffix.patch 1.04 KB

#5

Dave Reid - March 18, 2009 - 16:30
Status:active» reviewed & tested by the community

Applied the patch and all the options worked as expected. I also tried it with a dummy path_redirect.views.inc and a path_redirect.pages.inc and it picked them up correctly.

#6

Gábor Hojtsy - March 18, 2009 - 17:05
Version:6.x-2.x-dev» 5.x-2.x-dev
Status:reviewed & tested by the community» patch (to be ported)

Great, committed, thanks!

#7

Gábor Hojtsy - August 24, 2009 - 13:03
Version:5.x-2.x-dev» 6.x-2.x-dev
Status:patch (to be ported)» fixed

Since 5.x is not maintained, moving back to fixed.

#8

System Message - September 7, 2009 - 13:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.