I have a module directory structure like:

/sites/all/modules
  /path_redirect
    /genereate
      path_redirect_generate.info
      path_redirect_generate.module
    path_redirect.admin.inc
    path_redirect.info
    path_redirect.install
    path_redirect.module
    path_redirect.test

With Extract from all in directory "sites/all/modules/path_redirect", the path_redirect.admin.inc file is included in the pot file (expected).

With Extract from path_redirect (in the fieldset), path_redirect.admin.inc is not included in the pot file (unexpected).

With Extract from path_redirect_generate in the sites/all/modules/path_redirect/generate directory (in the fieldset), path_redirect.admin.inc is not included in the pot file (expected).

CommentFileSizeAuthor
#4 filename-suffix.patch1.04 KBgábor hojtsy
#3 filename-suffix.patch1.12 KBgábor hojtsy
screenshot_003.png24.01 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

And I'm using the very latest 6.x-2.x CVS branch.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Well, potx is trying to look for path_redirect.{any of the known extensions}, and .admin.inc is not a known extension. The file lookup pattern probably needs to be changed to {modulename}{.optional whatever}.{any of the known extensions}.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new filename-suffix.patch1.12 KB

Try this patch.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
StatusFileSize
new filename-suffix.patch1.04 KB

Duh, of course that was untested, so a typo was in there. Try this instead.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Reviewed & tested by the community

Applied the patch and all the options worked as expected. I also tried it with a dummy path_redirect.views.inc and a path_redirect.pages.inc and it picked them up correctly.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 6.x-2.x-dev » 5.x-2.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Great, committed, thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 5.x-2.x-dev » 6.x-2.x-dev
Status: Patch (to be ported) » Fixed

Since 5.x is not maintained, moving back to fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.