Posted by BWPanda on March 16, 2009 at 2:04am
5 followers
| Project: | Taxonomy menu |
| Version: | 6.x-2.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
A normal vocabulary edit page (without TM installed) has the Save button first, followed by the Delete button.
This module seems to change that around (so that Delete comes first) on line 68 of taxonomy_menu.module...
I think this should be changed back to how Drupal had it before, to save confusion.
Comments
#1
I agree with consistency. Otherwise users will delete accidentally.
#2
Didn't have time to create a patch before (on my way out to lunch), so here it is now...
EDIT: Oops, made the patch the wrong way around, see patch below instead :)
#3
Try this instead...
#4
Thanks BWPanda. I definitely agree and will commit tonight. Can someone else also please test so we can move it to RTBC?
#5
This is part of the latest DEV that will be availale on 3/16. Please test and I will add to stable.
#6
I'm updates this module, but positions still old.See attach
I'm added line 70 to taxonomy_menu.module $form['taxonomy_menu']['#weight'] = 9;
(because VTN Nodes consist in lines 582-584
// this is ugly, but it is even worth to have the Save/Delete buttons before the end
// (and if you know a cleaner way, post an issue with the solution!)
$form['submit']['#weight'] = 10;
$form['delete']['#weight'] = 11;
break;
)
#7
If you are using version 2.1 you've not updated the module to 2.x-dev which is where this patch was applied according to developer comments in this thread.
#8
#9
VeryMisunderstood but http://drupal.org/node/410170 posted
"#403022: Position of Save and Delete buttons by BWPanda (http://drupal.org/user/289407) Change the order of buttons."
#10
Ah, you're right. I did not realize there was a new release. I'll remark for you.
Evidentally Pav@drupal.ru is still seeing this issue
#11
So this is a conflict with another module? Taxonomy menu sets the weights like this:
<?php// move the buttons to the bottom of the form
$form['submit']['#weight'] = 49;
$form['delete']['#weight'] = 50;
?>
#12
indytechcook, jes i'm commented this lines and added line 70 to taxonomy_menu.module $form['taxonomy_menu']['#weight'] = 9;
#13
This has been implemented in both current stable and .dev versions. Marking as fixed until further notice.
#14
Automatically closed -- issue fixed for 2 weeks with no activity.