A normal vocabulary edit page (without TM installed) has the Save button first, followed by the Delete button.
This module seems to change that around (so that Delete comes first) on line 68 of taxonomy_menu.module...

I think this should be changed back to how Drupal had it before, to save confusion.

CommentFileSizeAuthor
#6 shot00345.jpg43.96 KBPaV@drupal.ru
#3 taxonomy_menu-403022-3.patch820 bytesAnonymous (not verified)
#2 taxonomy_menu-403022-2.patch820 bytesAnonymous (not verified)

Comments

vm’s picture

I agree with consistency. Otherwise users will delete accidentally.

Anonymous’s picture

Version: 6.x-2.0 » 6.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new820 bytes

Didn't have time to create a patch before (on my way out to lunch), so here it is now...

EDIT: Oops, made the patch the wrong way around, see patch below instead :)

Anonymous’s picture

StatusFileSize
new820 bytes

Try this instead...

indytechcook’s picture

Thanks BWPanda. I definitely agree and will commit tonight. Can someone else also please test so we can move it to RTBC?

indytechcook’s picture

Status: Needs review » Fixed

This is part of the latest DEV that will be availale on 3/16. Please test and I will add to stable.

PaV@drupal.ru’s picture

Version: 6.x-2.x-dev » 6.x-2.1
Status: Fixed » Needs review
StatusFileSize
new43.96 KB

I'm updates this module, but positions still old.See attach
I'm added line 70 to taxonomy_menu.module $form['taxonomy_menu']['#weight'] = 9;

(because VTN Nodes consist in lines 582-584

// this is ugly, but it is even worth to have the Save/Delete buttons before the end
// (and if you know a cleaner way, post an issue with the solution!)
$form['submit']['#weight'] = 10;
$form['delete']['#weight'] = 11;
break;
)

vm’s picture

Version: 6.x-2.1 » 6.x-2.x-dev

If you are using version 2.1 you've not updated the module to 2.x-dev which is where this patch was applied according to developer comments in this thread.

vm’s picture

Status: Needs review » Fixed
PaV@drupal.ru’s picture

VeryMisunderstood but http://drupal.org/node/410170 posted
"#403022: Position of Save and Delete buttons by BWPanda (http://drupal.org/user/289407) Change the order of buttons."

vm’s picture

Version: 6.x-2.x-dev » 6.x-2.1
Status: Fixed » Active

Ah, you're right. I did not realize there was a new release. I'll remark for you.

Evidentally Pav@drupal.ru is still seeing this issue

indytechcook’s picture

Status: Active » Postponed (maintainer needs more info)

So this is a conflict with another module? Taxonomy menu sets the weights like this:

// move the buttons to the bottom of the form
$form['submit']['#weight'] = 49;
$form['delete']['#weight'] = 50;
PaV@drupal.ru’s picture

indytechcook, jes i'm commented this lines and added line 70 to taxonomy_menu.module $form['taxonomy_menu']['#weight'] = 9;

Anonymous’s picture

Status: Postponed (maintainer needs more info) » Fixed

This has been implemented in both current stable and .dev versions. Marking as fixed until further notice.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.