Block page color issue

subscribe

Hi,

this weird issue happens in Firefox and Safari (not in IE) and it is caused by the border-collapse property:

table { defaults.css?G (line 21)
border-collapse:collapse;
}

and the 1.5em border used to give some top space between block_region rows and the above block_listing rows:

td.region, td.module, td.container, td.category { style.css?G (line 217)
...
border-top:1.5em solid #FFFFFF;
...
}

I tried different options and I ended up removing the 1.5em border and adding a span tag around the block_region header instead.

I have also added a new class "first-region" for the very first block_region element in order to remove the space between this and the table headers.

Hope this is a possible solution.

Thanks.

Angelo

-- Please note that this is my first patch.

subscribe

subscribe

ARep: Thanks for your first patch :) hopefully it's the first of many.

Please review the CSS coding standards at http://drupal.org/node/302199

Make sure to alphabetize all property declarations, and precede each declarations with 2 spaces instead of a tab. Also, the comment right above your CSS should look like this:

/**
 * Table drag and drop.
 */

/*
** Table drag and drop.
*/

I know that's not your comment but it'd be nice to get it fixed in the same patch since you're already right there.

Also, it seems like $row == 0 returns false, you'll have a space at the end of your classes (see the space between the ?> and <?php on that line).

This is a necessary patch...let's get it in there :)

Fixed -> Make sure to alphabetize all property declarations

Fixed -> precede each declarations with 2 spaces instead of a tab.

Fixed -> Also, the comment right above your CSS should look like this...
Please note: I changed the comments syntax everywhere there was an "old/wrong syntax comment" in the system.css file

Fixed -> Also, it seems like $row == 0 returns false, you'll have a space at the end of your classes (see the space between the ?> and <?php on that line)..
I added a space right before the class name (' first-region') in the if/end if statement so that when $row returns false there won't be any unnecessary space in the class attribute; I am not sure this is the right way to do it though.

This looks good. Let's get it in.

-/*
-** Table drag and drop.
+/**
+* Table drag and drop.
 */

These CSSDoc fixes are not correct. The asterisks need to be aligned in one column:

+/**
+ * Table drag and drop.
  */

So, either revert all those changes and defer them to a separate issue, or fix them properly. I wouldn't mind if you just revert, because we should fix those CSS comments to properly use CSSDoc in one fell swoop throughout core.

is this now a moot point with the intro of the "Seven" theme?

I just made Garland my admin theme and moved all the blocks around ... I believe that this issue has been fixed sometime in the last six months