node_assign_owner_action() logs an object type instead of the type name [#403034]

I have a log entry "Changed owner of Test to uid ...", if I click on it I get a blank screen.

Apache log says:
[Mon Mar 16 02:04:21 2009] [notice] child pid 26171 exit signal Segmentation fault (11)

Hu ? Just for the record:
PHP 5.2.6 with Suhosin-Patch 0.9.6.2 (cli) (built: Jan 19 2009 02:02:56)

I checked the watchdog table in the database:

Message:
Changed owner of @type %title to uid %name.

Variables:
a:3:{s:5:"@type";O:8:"stdClass":14:{s:4:"type";s:4:"book";s:4:"name";s:9:"Book page";s:6:"module";s:4:"node";s:11:"description";s:283:"A book page is a page of content, organized into a
collection of related entries collectively known as a book. A book page automatically displays links to adjacent pages, providing a simple navigation system for organizing and
reviewing structured content.";s:4:"help";s:0:"";s:9:"has_title";s:1:"1";s:11:"title_label";s:5:"Title";s:8:"has_body";s:1:"1";s:10:"body_label";
s:4:"Body";s:14:"min_word_count";s:1:"0";s:6:"custom";s:1:"1";s:8:"modified";s:1:"1";s:6:"locked";s:1:"0";s:9:"orig_type";s:4:"book";}s:6:"%title";s:4:"Test";s:5:"%name";s:9:"anewowner";}

The error lies in node.module:

/**
 * Implementation of a configurable Drupal action.
 * Assigns ownership of a node to a user.
 */
function node_assign_owner_action(&$node, $context) {
  $node->uid = $context['owner_uid'];
  $owner_name = db_result(db_query("SELECT name FROM {users} WHERE uid = %d", $context['owner_uid']));
  watchdog('action', 'Changed owner of @type %title to uid %name.', array('@type' => node_get_types('type', $node), '%title' => $node->title, '%name' => $owner_name));
}

node_get_types should be called with 'name' not 'type.

  watchdog('action', 'Changed owner of @type %title to uid %name.', array('@type' => node_get_types('name', $node), '%title' => $node->title, '%name' => $owner_name));

Comment	File	Size	Author
#11	403034-11_D6.patch	995 bytes	roderik
#11
#8	403034-node_assign_owner_action-type.patch	982 bytes	Damien Tournoud
#8
#4	403034_D6.patch	571 bytes	roderik
#4
#2	403034.patch	771 bytes	roderik
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

samuelet CreditAttribution: samuelet commented 1 December 2009 at 14:46

Version:

6.10

» 6.14

I confirm this bug also on 6.14.
This bug is related to #365298: Core "Change the author of a post" action not firing for assigned triggers where you can find the instructions to reproduce it.

Comment #2

roderik

Dutch

Amsterdam,NL / Budapest,HU

CreditAttribution: roderik commented 31 July 2010 at 00:33

Version:	6.14	» 6.17
Status:	Active	» Reviewed & tested by the community

File	Size
403034.patch	771 bytes

- bug encountered & traced independently
- this issue found and confirmed
- solution tested.
And it really is a 'typo' kind of thing, since all 'neighbor' functions use node_get_types('name', $node).

In the interest of not having this wait another 9 months... can I please act as if Andreas Wolf or nonsie (in duplicate issue) set the issue to 'needs review'? And I am setting it RTBC now?
Please? :)

Note: this is not a "fix in D7 first" case, since node_get_types() has died off.

Marking #460852: Minor change in node_assign_owner_action required duplicate.

Comment #3

31 July 2010 at 00:40

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 403034.patch, failed testing.

Comment #4

roderik

Dutch

Amsterdam,NL / Budapest,HU

CreditAttribution: roderik commented 31 July 2010 at 02:09

Status:

Needs work

» Needs review

File	Size
403034_D6.patch	571 bytes

Meh, test bot. I am so a non-core hacker...

Hope this is better. ('cvs diff' format, too.)

Comment #5

kndr

he/him

Polish

Rybnik, Poland

CreditAttribution: kndr commented 17 September 2010 at 10:39

Version:	6.17	» 6.19
Priority:	Normal	» Critical

Confirm this. In my environment (Pressflow 6.19.92) this bug breaks the site. I've got WSOD and error:

"The website encountered an unexpected error. Please try again later."

after trying to execute VBO action "Change the author of the post". It is broken since Devel module try to execute devel_watchdog() function with wrong parameters:

Recoverable fatal error: Object of class stdClass could not be converted to string in devel_watchdog() (line 430 of /public_html/sites/all/modules/devel/devel.module).

Patch #2 is correct - exactly the same works for me in 6.19 and Pressflow 6.19.92 installation. Commit, please, this simple patch.

Comment #6

roderik

Dutch

Amsterdam,NL / Budapest,HU

CreditAttribution: roderik commented 17 September 2010 at 22:38

Status:

Needs review

» Reviewed & tested by the community

So like, "in the interest of not having this wait for another 9 months"...

*changes status again, and quickly ducks & hides, hoping nothing will explode this time*

Comment #7

Damien Tournoud CreditAttribution: Damien Tournoud commented 17 September 2010 at 22:46

Title:	node.module provokes segmentation fault in log	» node_assign_owner_action() logs an object type instead of the type name
Version:	6.19	» 7.x-dev
Priority:	Critical	» Normal
Status:	Reviewed & tested by the community	» Patch (to be ported)