A quick review: many rough edges

Thanks for you time Wim, and the hints for solutions, much appreciated.

- About the least descriptive module name ever? "Two-level select" would've been, much, much more clear.

I guess it is, don't know if it is possible to change...

- No README.txt.

On its way.

- The CSS doesn't cooperate well with the nested fieldsets that follow. Without looking at the CSS, I think you're floating stuff left without clearing it.

Very possible, I have noted this behavior.

- It fails to work at all if you've got *anything* else than a 2-level vocabulary. Single level doesn't work and >2 levels produces weird results (terms at third level appearing as tabs, i.e. root level terms, etc.)

There will be checks to ensure that it is a 2-level taxonomy being acted upon.

- Coding style of the PHP is mostly correct, but not entirely.
- Not all functions are documented.

Noted and coming...

- $count = 0; outside of any function …
- Debugging leftovers: //var_dump($form);

All coming out

- theme_taxonomy_select_control() contains HTML, which is ok. What's not cool is that you're building lists through hardcoding HTML. Use theme('item_list', …)

The lists being built are possible with theme('item_list', ...)/theme_item_list() because we are doing a columned list, and the css/html issues around it require some massaging to be done. This is in a theme function, so it can still be overridden and needn't take on the characteristics of other lists on the site. I just hadn't gotten around to removing the bullets from the lists in the stylesheet.

- Only one vocabulary can be configured to use taxonomy_select

Acting on multiple is in the works

- Coding style of the JS isn't correct.
- Strings in the JS aren't run through Drupal.t().

Gonna have to brush up on my Drupal JS. I wasn't familiar with Drupal.t() and figured I would have to pass strings through with drupal_add_js(type=setting,...t('some text'),...) very helpful.

Thanks again,
Cheers