Output size and padding calculation broken

That's probably a good idea. It's officially on the to do-list.

Oh, that's a bad typo. Good catch.

Are you sure the padding needs to be a multiple of 2? In that case I think I should revert the code to what we had a couple of revisions ago:

<?php

      // Calculate new output size and padding.
      if ($orig_q > $dest_q) {
        // Width is the determining factor.
        $padding = round(($dest_y - ($dest_x / $orig_q)) / 2);
        // Make sure padding is divisible by 2, otherwise ffmpeg freaks out.
        $padding &= ~1;
        $pad = sprintf('-padtop %d -padbottom %d', $padding, $padding);
        $dest_y = round($dest_x / $orig_q);
      }
      elseif ($dest_q > $orig_q) {
        // Height is the determining factor.
        $padding = round(($dest_x - ($dest_y * $orig_q)) / 2);
        // Make sure padding is divisible by 2, otherwise ffmpeg freaks out.
        $padding &= ~1;
        $pad = sprintf('-padleft %d -padright %d', $padding, $padding);
        $dest_x = round($dest_y * $orig_q);
      }


?>

That doesn't take care of width and height being multiples of 2 though, but that's easy enough to add in.

Please try this patch. It's supposed to make all calculated values multiples of 2.

I went ahead and committed this patch, even though it hasn't been properly tested. I think it's an improvement to the current situation in any case. Testing of the -dev version would be greatly appreciated!