Posted by egfrith on March 16, 2009 at 1:31pm
| Project: | Bibliography Module |
| Version: | 6.x-1.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
I have downloaded a RIS file in which there is no space after the final"ER -"
With the current version of ris_parser.inc, which determine the tag by searching for " - ", this causes the ER tag not to be recognised, and the node is therefore not created.
According to the RIS spec, biblio's behaviour is correct. But the patch I will attach to the next comment fixes this behaviour by searching for " -" (note the absence of the final space). The extra resulting space should be take out by the subsequent trim(), so hopefully this fix is OK.
Comments
#1
#2
#3
Looks good, I just adjusted the start position to reflect the fact that there is one less character in the search string...
$value = trim(drupal_substr($line, $start +3)); // <- 3 instead of 4I've committed it to CVS.
Ron.
#4
Thanks for the quick response! The amended fix works fine.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.