I have downloaded a RIS file in which there is no space after the final
"ER -"

With the current version of ris_parser.inc, which determine the tag by searching for " - ", this causes the ER tag not to be recognised, and the node is therefore not created.

According to the RIS spec, biblio's behaviour is correct. But the patch I will attach to the next comment fixes this behaviour by searching for " -" (note the absence of the final space). The extra resulting space should be take out by the subsequent trim(), so hopefully this fix is OK.

CommentFileSizeAuthor
#1 biblio-403484-1.patch1016 bytesegfrith

Comments

egfrith’s picture

egfrith commented
StatusFileSize
new biblio-403484-1.patch1016 bytes
egfrith’s picture

egfrith commented
Status: Active » Needs review
rjerome’s picture

rjerome commented
Status: Needs review » Fixed

Looks good, I just adjusted the start position to reflect the fact that there is one less character in the search string...

$value = trim(drupal_substr($line, $start +3));  // <- 3 instead of 4

I've committed it to CVS.

Ron.

egfrith’s picture

egfrith commented

Thanks for the quick response! The amended fix works fine.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.