Shopping cart block not collapsed by default when name/arrow unclickable [#403504]

Due to lack of space in the layout I had the following combination of block settings for the shopping cart:
- Display the shopping cart block collapsed by default. CHECKED
- Make the shopping cart block collapsible by clicking the name or arrow. UNCHECKED

The result in UC2 beta3 was that the shopping cart was always collapsed, which is what I wanted. Now after upgrading to UC2 beta5 I noticed that these settings instead resulted in the shopping cart block always being expanded, the first option seems to be ignored due to the latter being unchecked.

Comment	File	Size	Author
#3	403504.cart_collapse.2.x.patch	1.41 KB	cha0s
#1	403504.cart_collapse.2.x.patch	958 bytes	cha0s

Comments

Comment #1

cha0s commented 20 April 2009 at 20:08

Status:

Active

» Needs review

Status	File	Size
new	403504.cart_collapse.2.x.patch	958 bytes

This'll fix it...

Comment #2

rszrama commented 23 April 2009 at 17:56

Status:

Needs review

» Needs work

The change was actually intentional, but I see your point. I don't think this patch can be used as is, because the JS only needs to be added when the block is !$cachable. Also, this creates some confusion in the block settings that the change was supposed to clear up (based on the language of the options).

All you really have to do if you always want the contents of the block to be hidden is use the same simple CSS that the JS activates:

#cart-block-contents {
  display: none;
}

Comment #3

cha0s commented 4 May 2009 at 04:51

Status	File	Size
new	403504.cart_collapse.2.x.patch	1.41 KB

Lemme know what you think of this patch...

Also fixes another bug, that is that the arrow wouldn't always be added in when necessary.

Comment #4

cha0s commented 4 May 2009 at 13:26

Assigned:	Unassigned	» cha0s
Status:	Needs work	» Needs review

Comment #5

rszrama commented 24 June 2009 at 16:24

Version:	6.x-2.0-beta5	» 6.x-2.x-dev
Status:	Needs review	» Needs work

I don't understand the need for the CSS hack or how it relates to the original issue. If something like that is indeed needed, drupal_add_css() is available in D5-7. Is the original poster still around on this?