Fixes for 4.7; security change

Cvbge - December 8, 2005 - 11:21
Project:Pathauto
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:mikeryan
Status:closed
Description

Hi.

There is no %u in db_query() anymore. %d is sufficient.

$prefix should be escaped, it's part of url IMO, % needs to be doubled.

AttachmentSize
02-pathauto.diff1.44 KB

#1

mikeryan - December 12, 2005 - 00:59
Assigned to:Anonymous» mikeryan

Thanks, I'll apply to CVS as soon as I have a little time this week...

#2

markus_petrux - December 16, 2005 - 13:46
Title:Fixes for 4.7, security change» Fixes for 4.7, another patch for the same file

node_list() is now node_get_types()

Please, see attached file.

AttachmentSize
pathauto_node.inc_1.patch399 bytes

#3

markus_petrux - December 16, 2005 - 13:49

This is the same patch above, hopefully using correct format. Sorry.

AttachmentSize
pathauto_node.inc_2.patch811 bytes

#4

markus_petrux - December 16, 2005 - 14:02

I just figured I generated the patch with an incorrect order of files.

Again, sorry. :(

Please, discard the patches above a see the one attached here.

AttachmentSize
pathauto_node.inc_3.patch811 bytes

#5

markus_petrux - December 16, 2005 - 14:29

And here's another fix for the same file:

Find this code:

$placeholders[t('[type]')] = pathauto_cleanstring(node_invoke($node->type,'node_name'));

and replace with:

$placeholders[t('[type]')] = pathauto_cleanstring(node_get_name($node));

#6

mikeryan - December 18, 2005 - 20:25
Status:patch (reviewed & tested by the community)» closed

Already been done.

#7

Cvbge - December 26, 2005 - 21:56
Status:closed» patch (reviewed & tested by the community)

My patch (first issue) is still valid.

#8

Cvbge - December 26, 2005 - 21:58
Title:Fixes for 4.7, another patch for the same file» Fixes for 4.7; security change

And the original title. Bad people stole my issue.

#9

markus_petrux - December 26, 2005 - 22:49

>> Bad people stole my issue.

1) No need for that, imo. 2) There is worst people out there. I just tried to be of some help (but honest, I was wrong because I didn't check cvs, sorry, new in this country), and I saw your thread related to "fixes for 4.7", so I posted here.

#10

mikeryan - January 2, 2006 - 22:41
Status:patch (reviewed & tested by the community)» fixed

The fixes from Cvbge have been committed to HEAD, thanks!

#11

Anonymous - January 16, 2006 - 23:00
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.