The latest update.php JS does not degrade, it seems. Update no longer works.

Makes me wonder: It may be to have JS, do we /really/ need this in update.php? Shoul update.php nost Just Work?
I know that this might make drupal appear more userfriendly, but if it breaks, it certainly *is* not more userfriendly.

In konq nothing hapens after hitting update. This is with the default locale, so the fact that there are still sme unt-ed strings in update.php does not cause this bug, afaiks.

Comments

Bèr Kessels’s picture

Bèr Kessels commented
Version: 4.6.3 » 4.7.0-beta1
MarcoZ’s picture

MarcoZ commented

I have seen this too when trying to update my test site from 4.6.4 to 4.7.0 Beta 1 today. The Update button simply won't do anything other than bringing me back to the front screen of update.php. This is with both IE and Firefox under Windows running PMP 4.6 PL1 and Apache 2.0.5, MySQL 5.0.15.

Bèr Kessels’s picture

Bèr Kessels commented
Title: update.php breaks (in konqueror?) » update.php does not show users when something goes fubar.

After hunting this bug for a while, I think I trapped it. At least I think I know where the problem comes from. The solution is simple: switch off JS :)

* It is not related to konqueror, FF and safari do the same
* It is not a JS bug, per se. It is a usability issue, caused by JS.
* The JS obfuscates and hides problems. Thus it appears as if everything is fine, while in the back evverything is just halted.
*

Whenever you get any sort of fatal error, PHP error or MYSQL fatal error, Drupal?php will just stop. Without JS this is clear, because you get to see the error. You see your throbber stopping, and you then know what to search for. Same goes for a timeout or a memory limit.

* I tested with a syntax error in PHP
* With node.module disabled.
* With a very low memory limit
* with a low timout and a lot of revisions
All these cases caused this bug to break my update, without me knozing that update is broken, because I cannot see the PHP errors.

With JS enabled, however, you dont see the throbber running (bad usability) You dont see any error output from PHP or Mysql, you just see a non-working progressbar.

So the solution is simple: dont use JS in the update form.
A real solution is harder, though. JS should promt you if PHP crashed, or the JS progressbar should disappear and the normal PHP error should appear, possibly with a link to drupals handbooks/FAQ.

Bèr Kessels’s picture

Bèr Kessels commented

part of this issue is fixed in http://drupal.org/node/40677

dopry’s picture

dopry commented
Version: 4.7.0-beta1 » 4.7.0-beta4

I still see no way to report php errors to JS progress bars... I think this is a critical 4.7 issue and more wide spread than update.php...

dopry’s picture

dopry commented
Status: Active » Closed (duplicate)

created issue 47510 with a more accurate description of the underlying problem. Marking this issue as duplicate.