The indentation is off in openid_help(). There is also an unnecessary extra blank line.

Comments

brianV’s picture

Reviewed, looks in accordance with the Coding Standards now.

Would suggest moving directly to RTBC, since it is just moving a line over by two spaces...

webchick’s picture

Status: Needs review » Patch (to be ported)
Issue tags: +Quick fix

@brianV: Just so you know, once you've reviewed an issue, if you feel it's ready to be committed, feel free to move the issue status to RTBC yourself. No special permissions required! :)

Committed to HEAD. Thanks!

Looks like 6.x needs a fix too, although the patch doesn't apply.

cwgordon7’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new1.57 KB

Drupal 6 patch attached.

cwgordon7’s picture

Version: 7.x-dev » 6.x-dev

Wrong branch, sorry.

brianV’s picture

webchick,

I thought about it, but the reviewing page in the handbook specifies that at least two experienced users should review a patch before being set to RTBC. I wasn't sure how much flexibility there was in that for occasions where the patch was so trivial...

webchick’s picture

Ah. Yes, in general that's a good rule to adhere to, so I'm glad the handbook says that. :)

However, in the case where it's one or two lines and it's a really obvious thing, just a single "yep, that looks good and doesn't blow anything up" (assuming you tested it and confirmed it doesn't blow anything up ;)) works for me!

brianV’s picture

Status: Needs review » Reviewed & tested by the community

D6 patch is good

gábor hojtsy’s picture

Priority: Normal » Minor
Status: Reviewed & tested by the community » Fixed

Thanks, committed to Drupal 6 too.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.