Closed (fixed)
Project:
Drupal core
Version:
6.x-dev
Component:
openid.module
Priority:
Minor
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
17 Mar 2009 at 01:43 UTC
Updated:
3 Jan 2014 at 00:07 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
brianV commentedReviewed, looks in accordance with the Coding Standards now.
Would suggest moving directly to RTBC, since it is just moving a line over by two spaces...
Comment #2
webchick@brianV: Just so you know, once you've reviewed an issue, if you feel it's ready to be committed, feel free to move the issue status to RTBC yourself. No special permissions required! :)
Committed to HEAD. Thanks!
Looks like 6.x needs a fix too, although the patch doesn't apply.
Comment #3
cwgordon7 commentedDrupal 6 patch attached.
Comment #4
cwgordon7 commentedWrong branch, sorry.
Comment #5
brianV commentedwebchick,
I thought about it, but the reviewing page in the handbook specifies that at least two experienced users should review a patch before being set to RTBC. I wasn't sure how much flexibility there was in that for occasions where the patch was so trivial...
Comment #6
webchickAh. Yes, in general that's a good rule to adhere to, so I'm glad the handbook says that. :)
However, in the case where it's one or two lines and it's a really obvious thing, just a single "yep, that looks good and doesn't blow anything up" (assuming you tested it and confirmed it doesn't blow anything up ;)) works for me!
Comment #7
brianV commentedD6 patch is good
Comment #8
gábor hojtsyThanks, committed to Drupal 6 too.