The tabledrag grippie is misaligned in IE7
mfer - March 17, 2009 - 03:00
| Project: | Drupal |
| Version: | 6.x-dev |
| Component: | drupal.css |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
| Issue tags: | Novice |
Description
The icon/grippie to drag tables at on admin/build/block are sitting to high and will even be over the border for the row above them when at the top of a region in IE6/IE7. This exists in D7 and D6.
Steven Merrill noted this at http://drupal.org/node/350275#comment-1364774
#1
tagging for novice queue
this would be good for a "JS/jQuery/CSS/IE-specific hacks" guru :)
#2
For whatever reason, IE6/7 doesn't pick up on the padding-top of the handle's anchor element. Since margin-top is almost equal to the negative of the padding, I just zeroed both. Seems to achieve the desired visual effect.
I've attached a screenshot of IE7. Someone please confirm it works for IE6. I'm pretty sure it does, but I don't have IE6 running in this box.
#3
Forgot to add that the CSS is still valid CSS 2.1. ^_^
#4
The last submitted patch failed testing.
#5
That's strange. The patch passed last time I checked. Let's re-test!
#6
I just tested in IE6 and it doesn't work. It looks like the CSS hack isn't being picked up as a valid selector, though I'm not sure how much I trust the IE6 webdeveloper toolbar. Perhaps this would be better fixed in the jQuery side of things? It does work as expected in IE7 and IE8 (which should ignore the CSS anyways).
FYI MS has IE VPC images available for website testing: http://www.microsoft.com/downloads/details.aspx?FamilyId=21EABB90-958F-4...
#7
Thanks for the IE VPC link!
I rendered it with IE6 and - you're right - the misalignment is still there. The CSS fix does work for IE7 though.
I've been playing around with margins and paddings and can't seem to effect the right change. I've managed to vertically centre the handle icon but the extra pixel still pops up when I hover over the handle. =(
#8
I can't figure out the IE6 fix. I've been using IETester to render my tests in IE6 (and IE7).
This patch is a re-roll of just the IE7 fix. To get this committed, I've forked the IE6 part to its own issue: #616620: The tabledrag grippie is misaligned in IE6. I'm not particularly interested in IE6 support, and don't want to spend more time on this.
#9
I tested in IE7, works fine to me (Vista, IE7, Drupal-6 version).