A jquery change

wkmit - March 17, 2009 - 11:05
Project:Known User Role
Version:6.x-1.2
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

I'm currently writing an ajax module that requires submitting a node form without refreshing the page.

I noticed in the 'You're logged in to Connect as Sally' string created (by this module) the username gets appended to the end after every request.
So after 5 form submission for example i would get this situation arising..
'You're logged in to Connect as SallySallySallySallySallySally'

I'm not totally sure if append is necessary, so i'll leave you to make the call.

In any case, it can be changed by simply replacing append with replaceWith in the lastuser.js file.
I have attached a patch. :)

AttachmentSize
lastuser_v1.patch798 bytes

#1

greg.harvey - March 29, 2009 - 17:34
Status:active» needs review

Thanks for the patch. Will take a look as soon as I get a chance. Without looking, I can't see any reason this won't get committed. =)

#2

greg.harvey - June 12, 2009 - 17:18
Status:needs review» fixed

Committed and in latest release! Thanks! =)

#3

System Message - June 26, 2009 - 17:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.