Closed (fixed)
Project:
Galleria
Version:
6.x-1.0-beta3
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
17 Mar 2009 at 16:50 UTC
Updated:
6 Apr 2009 at 19:10 UTC
I noticed on the Galleria website that the script allows thumbnails to be specified if desired. This is helpful, as the browser-based resizing can be of questionable quality. I've attached a patch that adds the ability to generate ImageCache based thumbnails for the Galleria. In addition to avoiding browser-based resizing, we get all the nice stuff that ImageCache can do to the image. Personally, I'm making them a uniform size, and supersaturating them.
I've looked the patch over a couple times, but if I missed anything important, feel free to let me know, and I'll take it from there. Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| galleria-6.x-1.0-beta3-imagecache-thumbs.patch | 3.76 KB | smithn.nc |
Comments
Comment #1
smithn.nc commentedOh, one other important note. Even when specific thumbnail images are defined, they will still be cropped down if they are bigger than what is defined in the CSS rule for ".item-list .galleria li". You can't just ignore that CSS because a thumbnail has been defined. Hope that helps!
Comment #2
Mark Theunissen commentedThanks, I have committed and cleaned up the code.
There were quite a few major deviations from Drupal's coding standards (i.e. the standard used in Galleria module), you may want to install and use the coder module in future to review your modifications before submitting. If this patch was any larger, I wouldn't have accepted it due to the large amount of time I have to spend cleaning it up and making it consistent with the other code.
Also check out the l() function for making links, rather than direct HTML. http://api.drupal.org/api/function/l
Thank you!
Comment #3
smithn.nc commentedAw. You really didn't have to do that. I would have gone back and changed things as needed, but thank you! I'll add the coder module onto my test install of Drupal for future work. Apologies for causing you to spend extra time in fighting with it.