Closed (fixed)
Project:
Apache Solr Search
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Mar 2009 at 19:41 UTC
Updated:
15 Jun 2010 at 21:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
JacobSingh commentedI think we have an issue for this already, but I don't see it.
@pwolanin: Do you know where it is?
And yes, I agree to the above points BUT it would be nice to have a *better* search framework so that users can seamlessly switch between Solr and Sphinx or back to core search without theming, etc issues.
So seeing as we don't have a better one, I'm a little reticent to move off of core search. I'm actually fine with it, but I think we should make sure we maintain compatibility.
Comment #2
pwolanin commentedhmm, I can't find it either.
Comment #3
coupet commentedIssues for Core searches
http://drupal.org/project/issues/coresearches
Comment #4
pwolanin commented@coupet - no, this would be an issue for just this module.
Comment #5
janusman commentedIt would be great if we could come up with the different scenarios for/against dependancy on core search. here's a possible starting list:
Cases when removal of core search dependancy is good:
* Don't need core search, and will no longer have core search indexing what is already on the Solr index.
* ??
Cases when it's bad:
* D7 or later gets the Search API it deserves, and Apache Solr module would have to "go back" and integrate with that.
* Would have to duplicate functionality offered in other modules (like OpenSearch which can now provide RSS for Apache Solr results).
* ??
Comment #6
David Lesieur commentedWould it be too far-fetched to support two interfaces, one that would stand by itself, and another based on hook_search(), by refactoring some stuff into separate modules?
Comment #7
pwolanin commented@David - that was basically my intention, since the amount of code specific to hook search is actually minimal.
Comment #8
David Lesieur commentedWith #469642: Pull facet blocks out of apachesolr_search.module (use facet_api), we could have a small step done to take some code out of apachesolr_search.module, to favor its re-use by other modules such as a potential search module that would not be dependent on core search.
Comment #9
pwolanin commentedLooking at this now - a little trickier than I initially thought since we use user_access('search content') and there is various block and theme code.
Comment #10
pwolanin commentedWIP, non-functional.
Comment #11
pwolanin commentedThinking about htis more - it would be easier to just form_alter to allow 0 nodes indexed by core node search (thanks Jody).
Comment #12
pwolanin commentednew title, patch.
Comment #13
Anonymous (not verified) commentedIt seems to work properly for me. :)
Comment #14
JacobSingh commentedCommitted...
Accidentally let CVS but the wrong comment in with -m on the command line once, but got it in proper.
Comment #15
damienmckennaThank you for this, I was really confused why core Search needed to be used given the entire engine was being replaced. I will give the next beta a good solid thrashing on a 70k+ node site.
Comment #17
moshe weitzman commentedThanks for this. I had to make a special accomodation for this clever hack in the search index command in drush. Search for Apachesolr at http://cvs.drupal.org/viewvc/drupal/contributions/modules/drush/commands...
Comment #18
geerlingguy commentedSubscribe. (Sorry, but I need it in my tracker).