When you install node_limit module the .install script tries to create the module tables but there is an error regarding wrong limit values, and it doesn't install right.

'default' => node_limit_NO_LIMIT)), >> 'default' => NODE_LIMIT_NO_LIMIT)),

Big change compared with other existing modules!

It would be nice to have also a rules integration that trigger an action when the limit has been reached (or a warning threshold limit) this way is possible to launch mails, messages, warnings, creation of new nodes....

CommentFileSizeAuthor
node_limit_install.patch697 bytesjcmarco

Comments

jcmarco’s picture

jcmarco commented
Status: Active » Needs review
Rosamunda’s picture

Rosamunda commented

I´ve tested it and it seems to work ok.
At least the error didn´t appeared anymore and just works. :)

davedelong’s picture

davedelong commented
Status: Needs review » Fixed

Patch has been applied and committed. Thanks for finding this. Remnants of a last minute name change. =P

Dave

webavant’s picture

webavant commented
Status: Fixed » Active

I'm still getting the error after checking out HEAD. I don't think the commit worked...

davedelong’s picture

davedelong commented
Status: Active » Postponed

I'm in the middle of a major overhaul of the 6.x branch, so if you're willing to hold off a couple days, I'll have a 0.1 release ready to put up. I've got the administrative interface done, a few sub-modules done, and part of the actual limitation done too. Hopefully another couple days (maybe by this Saturday) will give me enough time to finish.

Dave

g76’s picture

g76 commented

Sorry to bother you, I know you are busy, and your work on this is so much appreciated. I was just wondering when a newer 6.0 version would be released. This is a wonderful module, and og integration would be a blessing! I know that part is coming in the future, but just wanted a version I could install for now.

Again, thank you so much.

Jen

davedelong’s picture

davedelong commented

A preliminary version will probably be up on Saturday. OG integration will be a bit after that. Right now I'm focusing on getting the _user and _role submodules working (which isn't terribly difficult...). They'll be included in the next release. The node_limit_og module, judging by the demand I've observed, will probably be the next one after that. =)

Dave

davedelong’s picture

davedelong commented
Assigned: Unassigned » davedelong
Status: Postponed » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dungiis’s picture

dungiis commented

I applied this patch but it seems that the errors are still available. Do i have to apply this patch for node_limit.module file or node_limit.install file or something else ? I used GnuWin32

If you have free time! Could you guide me step by step for applying this patch ?

dungiis’s picture

dungiis commented

Sometimes, i also get the error like this

"patching file realname.module
Assertion failed: hunk, file ../patch-2.5.9-src/patch.c, line 354

This application has requested the runtime to terminate it in an unusual way. Please contact the application's support team for more info."

Any suggestion ?