Attached patch adds a 'create new ticket' link on the user's page if they can add new tickets. Also cleans up some little things. If you need me to separate out the add ticket from the cleanup, just let me know...

CommentFileSizeAuthor
jobtrack_cleanup.patch2.82 KBq0rban

Comments

jeremy’s picture

jeremy commented
Assigned: Unassigned » jeremy

I will review this before the next release. Assigning to myself.

jeremy’s picture

jeremy commented
Status: Needs review » Fixed

Looks good (cleanup included), thanks for the patch! Committed.

In the future, please separate cleanup from new features -- this should have been two issues.

q0rban’s picture

q0rban commented

Thanks!

Sorry, I knew to separate, just being lazy. :/

roball’s picture

roball commented

Hm, it seems that only users with the administer jobtrack permission see the Tickets section in their user profile (shown under History).

roball’s picture

roball commented
Status: Fixed » Active
q0rban’s picture

q0rban commented

roball, the user must have the 'create tickets' permission to see the 'View recent tickets' or 'Create new ticket' links.

If you're not seeing those even on users that have that permission, I'd open up a new issue about that, since the issue you just re-opened is a feature request, not a bug report.

q0rban’s picture

q0rban commented
Status: Active » Fixed
roball’s picture

roball commented
Status: Fixed » Active

The user I have been logged in as does have the create tickets permission, as well as edit own tickets, delete own tickets, can suppress notification and can assign tickets to other users. And, of course at least one access (CLIENT) tickets. I am able to create new tickets as this user, but the 2 links do NOT appear.

q0rban’s picture

q0rban commented
Status: Active » Fixed

Roball, that's very strange...

I'd open up a bug report about it, as the thread you're posting in is a feature request and has been fixed...

roball’s picture

roball commented
Status: Fixed » Active

How can you "fix" a feature request when the feature does not work?

jeremy’s picture

jeremy commented
Status: Active » Fixed

This is the design, as explained in this ticket. Feel free to open a new issue explaining what you'd like changed -- but take into account the security concerns in the linked issue. For example, it seems that what you want is that a user should be able to view his own profile links... anyway, please open a new issue as this issue is about adding a 'Create new ticket' link which is done.

roball’s picture

roball commented

Jeremy, OK, if you confirm my experience that the links on the profile page are only visible with administer jobtrack permission, than it's fine for me. But the description of this issue reads that these links should be visible with create tickets permission, so this leads to confusion. Not important for me, just thought it should work the way it was advertised.

q0rban’s picture

q0rban commented

Sorry, roball that was my confusion. I didn't realize that change had been made elsewhere (permissions). I agree with you that it seems unintuitive. Not sure the best solution, but it seems that there should be a view that just shows that particular users tickets. Easy to do with views if you wanted to do it yourself.

jeremy’s picture

jeremy commented

Fix committed.

roball’s picture

roball commented

Now the feature works perfectly. Thank you Jeremy and James!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.