Closed (fixed)
Project:
Database Administration
Version:
5.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
10 Dec 2005 at 11:20 UTC
Updated:
3 Dec 2006 at 20:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
dwwwhoops, just found this issue, after i had already submitted http://drupal.org/node/68276. not much here yet, and the CHANGELOG already refers to #68276, so i'm marking this as the duplicate.
Comment #2
dwwbah, so much for "cleaning up the issue queue". :) i should have read through the whole queue more closely. there's yet another older issue that my new ones were duplicate with. so, i'm going to do what's right, and open the oldest issues and mark the newer ones as the duplicates...
Comment #3
dwwwhile i was at it, i ported the delete row stuff to 4.7.x FAPI, too, and fixed the broken "Cancel" link there.
Comment #4
robertdouglass commentedthe 5 minute review says it looks good and works as advertised.
The only comment I had was that the "edit" and "delete" action links might be better placed at the far left of the table instead of the far right, but I realized that this would make it inconsistent with the table view page. On many tables, though, the action links are off the page in any browser size that I can open.
Comment #5
dwwthanks for the review/testing. and, perhaps moving the links would be a good move. however, that's a UI feature request. i was just trying to replicate the 4.6 functionality/UI as closely as possible. ;)
Comment #6
jeremy commentedLooks good, please merge.
Comment #7
dwwcommitted to HEAD as revision 1.44.
and now, time to make the branch and release nodes so we can finally close http://drupal.org/node/59073. ;)
Comment #8
finex commentedsoon I'll try the new version... good work :-)
Comment #9
(not verified) commented