The module is working well in Drupal 4.7, I've found only a bug when editing a row: you have the following error:

Fatal error: Call to undefined function: form_textfield() in /_MY_PATH_/dba/dba.module on line 540
CommentFileSizeAuthor
#3 dba_4.7_edit_delete_row.patch.txt8.83 KBdww

Comments

dww’s picture

Status: Active » Closed (duplicate)

whoops, just found this issue, after i had already submitted http://drupal.org/node/68276. not much here yet, and the CHANGELOG already refers to #68276, so i'm marking this as the duplicate.

dww’s picture

Title: Edit table row in 4.7 » 4.7 port: restore 'edit row' functionality
Status: Closed (duplicate) » Active

bah, so much for "cleaning up the issue queue". :) i should have read through the whole queue more closely. there's yet another older issue that my new ones were duplicate with. so, i'm going to do what's right, and open the oldest issues and mark the newer ones as the duplicates...

dww’s picture

Assigned: Unassigned » dww
Status: Active » Needs review
StatusFileSize
new8.83 KB

while i was at it, i ported the delete row stuff to 4.7.x FAPI, too, and fixed the broken "Cancel" link there.

robertdouglass’s picture

the 5 minute review says it looks good and works as advertised.

The only comment I had was that the "edit" and "delete" action links might be better placed at the far left of the table instead of the far right, but I realized that this would make it inconsistent with the table view page. On many tables, though, the action links are off the page in any browser size that I can open.

dww’s picture

thanks for the review/testing. and, perhaps moving the links would be a good move. however, that's a UI feature request. i was just trying to replicate the 4.6 functionality/UI as closely as possible. ;)

jeremy’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, please merge.

dww’s picture

Status: Reviewed & tested by the community » Fixed

committed to HEAD as revision 1.44.

and now, time to make the branch and release nodes so we can finally close http://drupal.org/node/59073. ;)

finex’s picture

soon I'll try the new version... good work :-)

Anonymous’s picture

Status: Fixed » Closed (fixed)