I've found another bug in dba: the CVS version of the database administration module (that I presume will be fully compatible with drupal 4.7), doesn't show the table checkbox in the ?q=admin/database page in HEAD/4.7beta1 version of Drupal.

CommentFileSizeAuthor
#14 dba_4.7_overview.patch_4.txt731 bytesdww
#11 dba_4.7_overview.patch_3.txt29.81 KBdww
#6 dba_4.7_overview.patch_2.txt30.78 KBdww
#5 dba_4.7_overview.patch_1.txt27.46 KBdww
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tfejos’s picture

tfejos CreditAttribution: tfejos commented

The same with 4.7 beta4. Checkbox and actions columns are completely missing.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Title: Table checkbox » 4.7 port: restore checkboxes next to table names on database overview
Priority: Normal » Critical
aam’s picture

aam CreditAttribution: aam commented
Status: Active » Closed (duplicate)

See patch submitted on the following issue too: "4.7 port: convert database overview according to new forms api"

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Closed (duplicate) » Active

I don't know how to write the patch for this, but I'm pretty sure it's not a duplicate.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Component: User interface » Code
Status: Active » Needs work
FileSize
dba_4.7_overview.patch_1.txt27.46 KB

actually, http://drupal.org/node/68500 is the one that's duplicate with this, and it's the newer issue, so i just marked it as such. i already added a needs-work patch and some comments there, but i'm moving back to the earliest issue...

here's my latest patch for this seemingly minor problem, which actually required fundamental re-design of dba.module for FAPI. ;)

it still doesn't work right for the "Check" operation on multiple tables, but otherwise it's pretty close...

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Assigned: Unassigned » dww
FileSize
dba_4.7_overview.patch_2.txt30.78 KB

ok, i got all the check stuff working now, too.
i think this is basically ready to go (it certainly works).
however, i'm a little nervous about some of the techniques employed. ;)
some close reviews would be appreciated.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Status: Needs work » Needs review
Jeremy’s picture

Jeremy CreditAttribution: Jeremy commented
Status: Needs review » Needs work

The check boxes do appear to work, that part's good. However I intentionally got rid of all the links after the name of the table -- it was too ugly and confusing. I replaced it with a simple link on the table name which took you to a view of that table and allows further actions with subtabs. If you want to perform an action on a table from the overview page, you have to check the box at the left then click the appropriate button at the bottom of the page.

Please leave the simpler interface, do not restore the ugly 4.6 look.

Also, what happened to the 'select all' / 'select none' links?

dww’s picture

dww
we/he/they
CreditAttribution: dww commented

hi jeremy, welcome back! ;)

good points on both fronts...

a) i thought the missing "action" links were a bug, not a feature, but i can certainly take them back out.

b) the "check all" javascript wasn't working and JS isn't my strength, so i just commented out the links on the overview page instead of adding links that don't work. personally, i'd consider that outside the scope of this patch... we should probably just make another bug report to restore that JS stuff...

i'll re-roll without the action links in a little while. stay tuned.

Jeremy’s picture

Jeremy CreditAttribution: Jeremy commented

Sounds like an excellent plan. I look forward to there finally being a 4.7 dba release.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Status: Needs work » Needs review
FileSize
dba_4.7_overview.patch_3.txt29.81 KB

a) removed the action links and turned the table name into a link to the view page
b) fixed the JS (just had a mis-match with the form id). ;)

Jeremy’s picture

Jeremy CreditAttribution: Jeremy commented
Status: Needs review » Reviewed & tested by the community

Excellent! Please merge.

With all four of these patches merged, I think we're ready to fork to 4.7.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Status: Reviewed & tested by the community » Fixed

committed to HEAD as revision 1.43.

as soon as i commit #40660, i'll make the branch, a 4.7.x-1.0 release, and i'll mark http://drupal.org/node/59073 fixed... stay tuned, we're almost there. ;)

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Status: Fixed » Needs review
FileSize
dba_4.7_overview.patch_4.txt731 bytes

crap. :( when i fixed the disagreement on the overview page's form_id, which was causing the JS select/deselect all stuff to not work, i ended up breaking the buttons entirely by leaving the name of the submit handler function wrong. grrr. sorry about that. i guess we'll need a 1.1 release sooner, rather than later. ;)

eaton’s picture

eaton CreditAttribution: eaton commented
Status: Needs review » Reviewed & tested by the community

Just tried it out on my 47 site. Works nicely. Hooray for the return of forms in dba!

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Version: 5.x-1.x-dev » 4.7.x-1.0
Status: Reviewed & tested by the community » Fixed

committed to DRUPAL-4-7 and HEAD.
thanks for the review, eaton! ;)

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)