Closed (fixed)
Project:
Administration menu
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Mar 2009 at 23:31 UTC
Updated:
6 Mar 2010 at 23:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
sunPatch?
Comment #2
mr.j commentedThis should work as it is an extremely simple 1 line fix (untested):
Comment #3
sunSee http://drupal.org/patch/create
Comment #4
mr.j commented1. I know how to make a patch. I was not at a dev machine when I tried to help you with a fix off the top of my head (notice it says untested).
2. It is a 1 line fix. Quicker for you to just do manually than bother with another patronising and unhelpful response instead of a little thanks.
3. Best of luck in the future, you've done enough to discourage me from fixing any more of your bugs.
Comment #5
sunYou might want to have a look at http://drupal.org/project/user/sun - my time permits me to mostly work on issues with patches only. If I'd do all of them myself, hell would break lose.
Glad you edited your comment and removed that
li;)Now consider what happened if I would have made the mistake. In this case, it may not have led to a failure, but the issue would not be resolved.
Comment #6
mr.j commentedOk then, no thanks for the fix. Cheers
I appreciate you have a lot to do, we all do .. but one word answers and pointing to patch instructions for the simplest of fixes without a hint of appreciation or thanks don't encourage people to participate much.
As for the error in the patch I corrected a minute after posting, good catch but what good is a patch-formatted fix if there is an error in it anyway? Not sure how you could have made the same mistake by copy+pasting a solitary line that I posted correctly originally (and if you think about it your insistence on a patch potentially led to the creation of an error).
Comment #7
sunCommitted a fix for this to 3.x. There won't be another 2.x release for 5.x.
Comment #9
traviscarden commentedCould we port this forward to 6.x? Attached is a patch. It will conflict with the patch I just submitted at #645526: Keep Themes from Affecting Local Tasks When Moved into Menu because they change lines right before and after each other, so I've also attached a combined patch containing both edits. I'm still fairly new to submitting patches, so please tell me if that's not the most helpful approach. Thanks so much!
Comment #10
sunThis seems to be fixed in 3.x already.
Also committed #645526: Keep Themes from Affecting Local Tasks When Moved into Menu