login and register links should take the user back to the same page

CommentFileSizeAuthor
#9 comment_forbidden2.patch3.6 KBmoshe weitzman
#8 comment_forbidden_0.patch3.58 KBmoshe weitzman
#6 comment_forbidden.patch3.5 KBmoshe weitzman
#4 40752.patch1021 bytesWesley Tanaka
comment-login-redirect.patch1017 bytesWesley Tanaka

Comments

Wesley Tanaka’s picture

Wesley Tanaka commented
Status: Active » Needs review
Wesley Tanaka’s picture

Wesley Tanaka commented
Title: login and regsiter links don't redirect back to the topic » login and regsiter links on each comment don't redirect back to the topic
dries’s picture

dries commented
Status: Needs review » Needs work

Your code is vulnerable to XSS attacks.

Wesley Tanaka’s picture

Wesley Tanaka commented
Status: Needs work » Needs review
StatusFileSize
new 40752.patch1021 bytes
Wesley Tanaka’s picture

Wesley Tanaka commented

just confirmed that patch still applies against 4.7.0-test2

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new comment_forbidden.patch3.5 KB

i made the destination smarter so that it links to the right page depending on whether comments are being displayed on other page or not.

i also fixed a logic bug when displaying this link on nodes. the link would not show up when comment form was placed on own page.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

Incorrect use of url(). Fragments can be passed as the third argument so no need to fudge with urlencode(). Patch has tabs.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new comment_forbidden_0.patch3.58 KB

rerolled with proper use of url(). thanks.

moshe weitzman’s picture

moshe weitzman commented
StatusFileSize
new comment_forbidden2.patch3.6 KB

now without tabs

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)