if a user doesn't type a subject for a comment, it's left blank, which makes links to the comment (like in the comment block) not have anything to click on.

CommentFileSizeAuthor
fillsubject.patch1.98 KBWesley Tanaka

Comments

Wesley Tanaka’s picture

Wesley Tanaka commented
Status: Active » Needs review
Wesley Tanaka’s picture

Wesley Tanaka commented

FYI this is one of the patches from http://drupal.org/node/35726. I can't find the original bug report that got marked as duplicate of 35726

finex’s picture

finex commented

The patch works on CVS. Now the subject is the first 29 chars of the comment?

grohk’s picture

grohk commented

Testing this patch on my site. So far it is working like a champ.

Wesley Tanaka’s picture

Wesley Tanaka commented

confirmed that patch still applies against 4.7.0-test2

torgeirb’s picture

torgeirb commented
Status: Needs review » Reviewed & tested by the community

I've reproduced the problem on HEAD, and patch looks good.

Suggestion: add a '...' at the end of the autofill thingy?

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

We don't glue words together (fillsubject).

Rather than passing a $form_values, how about passing a single field?

Wesley Tanaka’s picture

Wesley Tanaka commented
Status: Needs work » Fixed

On recent copies of CVS, patch has started reporting that this has already been applied.

After applying http://drupal.org/node/45723 to get past a blocking bug, it appears that this has been fixed in CVS.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)