the comment block is completely unconfigurarable

CommentFileSizeAuthor
#9 40755_0.patch1.54 KBWesley Tanaka
#5 40755.patch1.54 KBWesley Tanaka
comment.block.patch2.29 KBWesley Tanaka

Comments

finex’s picture

finex commented

Ok, the patch works in CVS!

Wesley Tanaka’s picture

Wesley Tanaka commented

patch still applies against 4.7.0-test2

Tobias Maier’s picture

Tobias Maier commented

I think it would be better to introduce a theme_comment_block() function so we can change the whole look and not only some visual settings

killes@www.drop.org’s picture

killes@www.drop.org commented
Category: bug » feature
Priority: Critical » Normal
Status: Needs review » Needs work

I agree with Tobias. In any case this is neither a bug nor critical.

Wesley Tanaka’s picture

Wesley Tanaka commented
Title: comment block completely hard-coded » comment block outputs hard-coded non-themeable html
Category: feature » bug
Status: Needs work » Needs review
StatusFileSize
new 40755.patch1.54 KB
Wesley Tanaka’s picture

Wesley Tanaka commented

Trying to distinguish between bug and feature without a spec is a bit academic, but I was under the impression that the (as far as i know, implicit and undocumented) specification of drupal is that it shouldn't be outputting things that can't be themed.

That certainly seems to be the philosophy, and one of the things that attracted me about the project in the first place.

Tobias Maier’s picture

Tobias Maier commented
Status: Needs review » Needs work

we want that the code and style/theme gets completely seperated.
You have a sql query in your theme-function
please modify it so that it gets an array with comments... (maybe you have to introduce a second helper function...)
thanks tobi

chrisada’s picture

chrisada commented

+1 for the idea.

I find the hard coded comment area very inflexible.

Wesley Tanaka’s picture

Wesley Tanaka commented
StatusFileSize
new 40755_0.patch1.54 KB

The problem is the hard coded 10 is being passed to the SQL function. Is there a mechanism other than theme functions (rejected in comment #7), hook callbacks (not appropriate here) or configuration variables (rejected in comment #3) that can be used to get a piece of data (like a replacement count) into the system?

Unless by second helper function you mean a second theme function that doesn't return HTML, but instead returns the data structure...

Attaching a (untested) patch which I don't think you're actually suggesting.

Wesley Tanaka’s picture

Wesley Tanaka commented
Status: Needs work » Needs review
dries’s picture

dries commented
Status: Needs review » Fixed

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)