necessary for drupal's forums to be used on any forum where the site administrator is not acting as the forum moderator, or where there are several forum moderators.

CommentFileSizeAuthor
#4 comment-edit-shows-comment-author.patch744 bytesWesley Tanaka
#2 comment-moderator-bug40758.patch2.25 KBWesley Tanaka
comment.moderator.patch3.69 KBWesley Tanaka

Comments

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Needs work

code looks good, but does not apply cleanly

Wesley Tanaka’s picture

Wesley Tanaka commented
Status: Needs work » Needs review
StatusFileSize
new comment-moderator-bug40758.patch2.25 KB
moshe weitzman’s picture

moshe weitzman commented
Priority: Critical » Normal

tested and code reviewed. the code looks good. a couple glitches ...

- users with this permission should be able to use the admin/comment page. they can do all that is shown there individally, lets give them the power interface.
- when an admin edits a comment, the owner of the does not change. when the new editor does, the owner changes. not desirable.
- maybe rename the new permission to 'maintain comments' for consistency with book.module? not sure about that.

this will be a sweet feature for forum admins on drupal.org.

Wesley Tanaka’s picture

Wesley Tanaka commented
StatusFileSize
new comment-edit-shows-comment-author.patch744 bytes

- when an admin edits a comment, the owner of the does not change. when the new editor does, the owner changes. not desirable.

Thanks for the catch! I don't get this behavior, but I'm maintaining about 25 patches on top of drupal, so it could have been fixed in one of those other patches. If you apply this patch (in addition to the one in comment #2), does that fix this issue?

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Needs work

alas, thats didn't fix it ... if anyone gets a chance, please investigate and post a new patch.

Wesley Tanaka’s picture

Wesley Tanaka commented

I tested patching a stock HEAD with the both patches, and I couldn't reproduce the behavior you reported of the author changing.

moshe weitzman’s picture

moshe weitzman commented

that odd username reset might have been caused by http://drupal.org/node/50755

Wesley Tanaka’s picture

Wesley Tanaka commented

Does that mean that this patch does work for you now?

Jaza’s picture

Jaza commented
Version: x.y.z » 6.x-dev
Status: Needs work » Closed (won't fix)

I don't think that this is really needed. Users who can edit comments will always need access to the 'admin/content/comment' page, so that they can see what comments are available for, or in need of, editing. Also, there's no reason why users with 'administer comments' permission need to have access to anything else in the site's admin area.