as I split up the comment megapatch, I feel that this is a duplicate, since i remember dries commenting on this issue somewhere. will mark as such if i find the other bug.

CommentFileSizeAuthor
comment.user.patch453 bytesWesley Tanaka

Comments

Wesley Tanaka’s picture

Wesley Tanaka commented

I marked http://drupal.org/node/40566 as a duplicate of this bug.

killes@www.drop.org’s picture

killes@www.drop.org commented

I amnot convinced we need this patch. Storing the default will only bloat the database and will make changing the default not take an effect.

killes@www.drop.org’s picture

killes@www.drop.org commented
Priority: Critical » Minor

no way critical.

Wesley Tanaka’s picture

Wesley Tanaka commented

The problem is that a "0" value gets (or got -- I haven't looked at this for a long time now) interpreted in two different ways.

In some cases it means "use the site's default setting".

In other cases, it means COMMENT_MODE_FLAT_COLLAPSED or COMMENT_ORDER_NEWEST_FIRST.

Newly registered users are getting sort and mode set to 0 without this patch, and that gets interpreted in the second fashion, even if the site default is set to something else.

Wesley Tanaka’s picture

Wesley Tanaka commented

I'm not sure what "bloat the database" means. Usually a "2" or a "3" takes up the same amount of space as a "0".

Wesley Tanaka’s picture

Wesley Tanaka commented

fixed as of comment.module revision 1.455

Wesley Tanaka’s picture

Wesley Tanaka commented
Status: Needs review » Fixed
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)