Active
Project:
Content Profile
Version:
6.x-1.x-dev
Component:
Base module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Mar 2009 at 02:51 UTC
Updated:
16 Apr 2009 at 20:21 UTC
While trying to theme my user profile pages with 5 different Content Profile types, I found that the function content_profile_show_profiles on line 479 of the Feb 03 dev release failed to wrap the "Create your links in the prefix and suffix tags (as defined on lines 510 and 511 respectively) if they came after a content type that existed. While trying to figure out why, and make them more CSS addressable, it became easier to just change the way these are handled with div tags. So, to that end, I've attached a set of patches of my changes for your review.
| Comment | File | Size | Author |
|---|---|---|---|
| content_profile.module.patch | 974 bytes | fred0 | |
| content_profile.css_.patch | 250 bytes | fred0 | |
| content_profile-display-view.tpl_.php_.patch | 514 bytes | fred0 |
Comments
Comment #1
fago+1 for better themability, but please also note #421980: remove HTML from .module code.
So shouldn't we try to remove any html out of theme functions?
Comment #2
fred0 commentedYes, I would agree with the idea of removing html from the module.