Directory structure not correct

kirie - March 20, 2009 - 13:45
Project:SOAP Client
Version:6.x-1.x-dev
Component:Miscellaneous
Category:task
Priority:normal
Assigned:ilo
Status:closed
Description

The directory structure of the project seems to be messed up. When I unpack the module I get the following structure:
/soapclient/modules/soapclient/soapclient.module instead of the expected /soapclient/soapclient.module.

#1

carlillos - July 14, 2009 - 11:43

I notice the same, anyone has a solution?

#2

ilo - September 17, 2009 - 19:34
Assigned to:Anonymous» ilo

I'll do, but probably this one will require an update function to change module files path in the system table.

#3

ilo - September 17, 2009 - 22:04
Status:active» needs work

I have had a little conversation with litwol on ric and we tested an upgrade path that may work, but requires manual operation from the administrator.

With the files located in the right directory (/soapclient/soapclient.module), just a drop to overwrite the project folder will not work, because there will be two different versions of each module file (/soapclient/modules/soapclient/soapclient.module and /soapclient/soapclient.module).

The upgrade path will be:
- put site offline
- remove soapclient folder <-- this is the important one
- put new soapcilent folder
- run update
- put site online

that is generally the right way to do, but the old folder should be deleted or the Drupal will stuck, as being unable to know wich of the two files is the good one.

If you all agree with this upgrade path then I'll commit the changes in project file structure.

#4

ilo - September 17, 2009 - 23:22

As this issue will require to move files, maybe is a good chance to resolve: #408360: NuSOAP project code should not be in CVS

I've included the install file I created to test the upgrade path, but will not commit this for now. The install file should go in, it includes the uninstall hook, but I'm not sure about including the update function.

AttachmentSize
soapclient.install.txt 2.38 KB

#5

ilo - October 12, 2009 - 23:52
Status:needs work» fixed

Commited to 6.x-1.x-dev

The worst of this commit is that history of the module was created again (these are new files). So I decide to do commit this as soon as possible to start creating new revisions with future changes.

When updating the module we should care about the update path, old files should be deleted manually (as suggested in the update path, remove old folder, download and create new folder).

#6

System Message - October 27, 2009 - 00:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.