Transliterization should occur before punctuation cleanup [#408420]

Hello

I have transliterization enabled at my site and catch that some russian letters are being transformed to apostroph sign (') which mallforms URL and it not opens. This thing happens because transliterization is coming after punctuation cleanup.

Here's the patch.

Comment	File	Size	Author
#2	408420-move_transliteration_earlier-2-d6.patch	1.82 KB	Freso
#2	408420-move_transliteration_earlier-2-d5.patch	2.11 KB	Freso
#1	pathauto_transliterization.patch	1.67 KB	neochief
	pathauto_transliterization.patch	1.54 KB	neochief

Comments

Comment #1

neochief commented 20 March 2009 at 14:58

Status	File	Size
new	pathauto_transliterization.patch	1.67 KB

Pard me, too fast buggy patch. Here's correct one.

Comment #2

Freso commented 21 March 2009 at 06:21

Status	File	Size
new	408420-move_transliteration_earlier-2-d5.patch	2.11 KB
new	408420-move_transliteration_earlier-2-d6.patch	1.82 KB

Thanks for catching this - and well caught! :)

This new behaviour is probably how it ought to be. It doesn't make sense to remove punctuation and stuff, when we still have a bunch of non-ASCII strings in the text. I'm wondering whether we should toss the ASCII-stripping in here, after the transliteration?

On the patch, I moved the comment "Replace or drop punctuation based on user settings" so it would be next to the code it actually commented on. So here's a re-roll! :) The -d5 is for 5.x-2.x and 6.x-1.x (applies to both, though with some offset to one) and -d6 is for 6.x-2.x.

I don't see how this would break anything, but if anyone could test these, it'd be excellent. Thank you. :)