HTML4/XHTML validation issue

markus_petrux - December 12, 2005 - 08:07
Project:Control Panel
Version:4.7.x-1.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:der
Status:closed
Description

Hi!

The validator reports an error related to the links generated within the function theme_controlpanel_panel_view(). It seems anchor tags can't contain div elements. Also the IMG and BR tags are not correctly terminated.

Maybe instead of:

<a href=...>
  <div>
    <img src=... >
    <br> ...title...
  </div>
</a>

Something like this?

<a href=...>
  <span style="display:block;">
    <img src=... />
    <br /> ...title...
  </span>
</a>

#1

markus_petrux - December 12, 2005 - 08:21

Another little problem, fieldsets are not correctly closed. hmm...

#2

markus_petrux - December 12, 2005 - 08:57

I hope it helps, I have fixed the above mentioned issues and a couple more related to output generated by this module.

Please, see attached file.

AttachmentSize
controlpanel.module 10.39 KB

#3

der - December 17, 2005 - 21:33
Status:active» needs work

Thanks Markus, but can you provide this in a patch instead of the whole module?

Thanks

#4

markus_petrux - December 17, 2005 - 23:27

Oh sorry, I just started to use the 'generate patch' function in WinMerge yesterday.

Please see attached file.

AttachmentSize
controlpanel.module.patch 3.17 KB

#5

der - January 2, 2006 - 23:36
Assigned to:Anonymous» der
Status:needs work» fixed

patch applied

#6

Anonymous - January 16, 2006 - 23:40
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.