Download & Extend
Control Panel » Issues

HTML4/XHTML validation issue

Posted by markus_petrux on December 12, 2005 at 8:07am
Project:Control Panel
Version:4.7.x-1.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:der
Status:closed (fixed)

Issue Summary

Hi!

The validator reports an error related to the links generated within the function theme_controlpanel_panel_view(). It seems anchor tags can't contain div elements. Also the IMG and BR tags are not correctly terminated.

Maybe instead of:

<a href=...>
  <div>
    <img src=... >
    <br> ...title...
  </div>
</a>

Something like this?

<a href=...>
  <span style="display:block;">
    <img src=... />
    <br /> ...title...
  </span>
</a>
Login or register to post comments

Comments

#1

Posted by markus_petrux on December 12, 2005 at 8:21am

Another little problem, fieldsets are not correctly closed. hmm...

#2

Posted by markus_petrux on December 12, 2005 at 8:57am

I hope it helps, I have fixed the above mentioned issues and a couple more related to output generated by this module.

Please, see attached file.

AttachmentSize
controlpanel.module 10.39 KB

#3

Posted by der on December 17, 2005 at 9:33pm
Status:active» needs work

Thanks Markus, but can you provide this in a patch instead of the whole module?

Thanks

#4

Posted by markus_petrux on December 17, 2005 at 11:27pm

Oh sorry, I just started to use the 'generate patch' function in WinMerge yesterday.

Please see attached file.

AttachmentSize
controlpanel.module.patch 3.17 KB

#5

Posted by der on January 2, 2006 at 11:36pm
Assigned to:Anonymous» der
Status:needs work» fixed

patch applied

#6

Posted by Anonymous on January 16, 2006 at 11:40pm
Status:fixed» closed (fixed)