Hi!

The validator reports an error related to the links generated within the function theme_controlpanel_panel_view(). It seems anchor tags can't contain div elements. Also the IMG and BR tags are not correctly terminated.

Maybe instead of:

<a href=...>
  <div>
    <img src=... >
    <br> ...title...
  </div>
</a>

Something like this?

<a href=...>
  <span style="display:block;">
    <img src=... />
    <br /> ...title...
  </span>
</a>
CommentFileSizeAuthor
#4 controlpanel.module.patch3.17 KBmarkus_petrux
#2 controlpanel.module10.39 KBmarkus_petrux

Comments

markus_petrux’s picture

markus_petrux commented

Another little problem, fieldsets are not correctly closed. hmm...

markus_petrux’s picture

markus_petrux commented
StatusFileSize
new controlpanel.module10.39 KB

I hope it helps, I have fixed the above mentioned issues and a couple more related to output generated by this module.

Please, see attached file.

dreed47’s picture

dreed47 commented
Status: Active » Needs work

Thanks Markus, but can you provide this in a patch instead of the whole module?

Thanks

markus_petrux’s picture

markus_petrux commented
StatusFileSize
new controlpanel.module.patch3.17 KB

Oh sorry, I just started to use the 'generate patch' function in WinMerge yesterday.

Please see attached file.

dreed47’s picture

dreed47 commented
Assigned: Unassigned » dreed47
Status: Needs work » Fixed

patch applied

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)