contrib\imagecache.inc code

brenk28 - March 20, 2009 - 21:17
Project:Install Profile API
Version:6.x-2.0
Component:Other
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Based on the fact that it is looking for 'action' as index to the passed array, I think the function install_imagecache_add_preset, line 30 needs to be changed from:

$action['data'] = $data;

to

$action['data'] = $data['data'];

Otherwise, the data does not get properly inserted into the table.

Also, as currently structured, the comment up top is incorrect: "Each action is itself an array with indexes of action, weight" ... it does not look for 'weight' index

#1

James Andres - April 6, 2009 - 17:45
Status:active» needs review

Visually confirmed by backtracing the imagecache_action_save() function in imagecache.module.

I'm not using install_imagecache_add_preset() in any of my code. Could somebody please test this patch?

AttachmentSize
imagecache.inc_.data-fix.patch 0 bytes

#2

James Andres - April 6, 2009 - 17:47

Weird .. no patch upload, here it is again.

AttachmentSize
imagecache.inc_.data-fix.patch 723 bytes

#3

James Andres - September 24, 2009 - 17:49
Status:needs review» fixed

Committing this bug fix, finally!

#4

System Message - October 8, 2009 - 17:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.