If a patch deletes a file, pifr will return "Failed: Invalid PHP syntax". see #340940: code-style.pl should be removed from core for an example.

Also, shouldn't certain filetypes be excluded from the PHP syntax check anyway (Perl, CSS, etc)?

CommentFileSizeAuthor
#2 pifr-408982.patch813 bytesboombatower

Comments

boombatower’s picture

boombatower commented

The reason I left out file exclusion (by type) is that would lead to yet another thing that PIFR needs to maintain. We already have an issue with the installer.

Looking into bug.

boombatower’s picture

boombatower commented
Version: 6.x-1.5 » 6.x-1.x-dev
Assigned: Unassigned » boombatower
Status: Active » Needs review
StatusFileSize
new pifr-408982.patch813 bytes

I knew this sounds familiar, #370750: Syntax checking only works with CVS generated patches.

JamesAn’s picture

JamesAn commented

The fix seems reasonable. This is my first time looking at PIFR, but I'm just here to bump the issue.

#417560: Move test files into tests/ and #418760: Move test files into tests/ both depend on this issue to correctly pass the automated patch tester.

boombatower’s picture

boombatower commented

Then I need to get in contact with hunmonk to update the server network.

boombatower’s picture

boombatower commented
Status: Needs review » Fixed

Committed. Just need to deploy.

boombatower’s picture

boombatower commented

Deployed.

JamesAn’s picture

JamesAn commented

Yey! ^_^

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.