When you clear the submit button text, you expect the button to disappear, instead, it shows the button but with no text at all.

I'm submitting a patch to add this feature/bug, I added a new option, "Show Nothing", and if it's selected it will unset the form[submit].

Patch it's against beta1, my bad. You can change the "Show Nothing" to something more likely.

please test.

Comments

jweberg’s picture

Status: Needs review » Needs work

Thanks for the patch. However, this doesn't seem to trigger the search results. When I enter text in the box and hit enter, the results page doesn't load.

jweberg’s picture

I fixed a bug in Beta1. Please make your patch to the dev. Thanks.

jweberg’s picture

Version: 6.x-1.0-beta1 » 6.x-1.x-dev
lelizondo’s picture

I'm having a lot of issues here. I tried to create the patch but couldn't figure out why unset(); returns nothing. Then I tried to go the easy way and set attributes to hide the button with:

'#attributes' => array('style' => 'display:none;'),

But if I have something in the Search form default, it just takes that value, ex. if I have 'search here' in the Search form default field, it will search the words 'search here' no matter what I'm trying to search.

Then I restored the dev to start over and I found out that no matter what I'm searching, the search results are always blank.

I'm stuck here. Can you confirm this?

Edit: Dev now works..

lelizondo’s picture

StatusFileSize
new758 bytes

Ok, now it works. Please test.

lelizondo’s picture

Status: Needs work » Needs review
lelizondo’s picture

StatusFileSize
new1.35 KB

I forgot the search_theme_form case

jweberg’s picture

Status: Needs review » Fixed

Great work. Commited. I will include this in the next beta.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.