When you clear the submit button text, you expect the button to disappear, instead, it shows the button but with no text at all.
I'm submitting a patch to add this feature/bug, I added a new option, "Show Nothing", and if it's selected it will unset the form[submit].
Patch it's against beta1, my bad. You can change the "Show Nothing" to something more likely.
please test.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | custom_search_box_new2.patch | 1.35 KB | lelizondo |
| #5 | custom_search_box_new.patch | 758 bytes | lelizondo |
| custom_search.patch | 1.39 KB | lelizondo |
Comments
Comment #1
jweberg commentedThanks for the patch. However, this doesn't seem to trigger the search results. When I enter text in the box and hit enter, the results page doesn't load.
Comment #2
jweberg commentedI fixed a bug in Beta1. Please make your patch to the dev. Thanks.
Comment #3
jweberg commentedComment #4
lelizondo commentedI'm having a lot of issues here. I tried to create the patch but couldn't figure out why
unset();returns nothing. Then I tried to go the easy way and set attributes to hide the button with:But if I have something in the Search form default, it just takes that value, ex. if I have 'search here' in the Search form default field, it will search the words 'search here' no matter what I'm trying to search.
Then I restored the dev to start over and I found out that no matter what I'm searching, the search results are always blank.
I'm stuck here. Can you confirm this?
Edit: Dev now works..
Comment #5
lelizondo commentedOk, now it works. Please test.
Comment #6
lelizondo commentedComment #7
lelizondo commentedI forgot the search_theme_form case
Comment #8
jweberg commentedGreat work. Commited. I will include this in the next beta.