Simpletest.install has a few minor problems:
- There are a few instances of using t() and not $t() in simpletest_requirements().
- The schema descriptions should not be using t().
- Using db_query instead of update_sql in simpletest_update_N functions where possible.

CommentFileSizeAuthor
#1 409384-simpletest-install-cleanup-D6.patch6.49 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 409384-simpletest-install-cleanup-D6.patch6.49 KB
boombatower’s picture

boombatower commented
Project: SimpleTest » Drupal core
Version: 6.x-2.x-dev » 7.x-dev
Component: Code » simpletest.module

These changes appear to apply to Drupal 7 as it has the same code, please fix there and then backport.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Project: Drupal core » SimpleTest
Version: 7.x-dev » 6.x-2.x-dev
Component: simpletest.module » Code

Actually they don't anymore. These only apply for the contrib simpletest module.

boombatower’s picture

boombatower commented
Status: Needs review » Postponed (maintainer needs more info)

Then it should automatically be included with my next backport.

boombatower’s picture

boombatower commented
Status: Postponed (maintainer needs more info) » Postponed
boombatower’s picture

boombatower commented
Status: Postponed » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.