Project:CAPTCHA
Version:6.x-2.x-dev
Component:Translation
Category:task
Priority:minor
Assigned:domasj
Status:closed (fixed)

Issue Summary

Changes:

  • Removed outer <p> tags from t() function to make translations cleaner.
  • Fixed some typos.
  • Enabled captcha_wrong_response_counter pluralization.
  • Generated new .pot template, got an error which I ignored: The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there.
    At watchdog('CAPTCHA',$errmsg,$errvar,WATCHDOG_ERROR) in image_captcha/image_captcha.user.inc on line 72.
  • Updated existing translations using new template.
  • Added Lithuanian translation.
AttachmentSizeStatusTest resultOperations
captcha_translation.diff160.2 KBIgnored: Check issue status.NoneNone
lt.po32.08 KBIgnored: Check issue status.NoneNone

Comments

#1

Category:bug report» task
Status:needs review» needs work

Thanks,
I already committed the code parts of you patch (http://drupal.org/cvs?commit=186986), except:

  • I did the captcha_wrong_response_counter pluralization with one format_plural() instead of a t() and a format_plural().
  • I removed all t()s from the database schema stuff in captcha.install because those strings do not have to be translatable (see Drupal core's modules)

I also regenerated the .pot template based on the new code: http://drupal.org/cvs?commit=187004

I added your Lithuanian translation: http://drupal.org/cvs?commit=187008

I did not yet update the existing (and your Lithuanian) translations to the updated .pot template.

#2

Component:User interface» Translation
Status:needs work» fixed

http://drupal.org/cvs?commit=233102

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here