I think we should only use one theming-engine.
so that - if the user wants to customize a theme does not need to learn how to use the specific theming-engine...
therefore I converted chameleon-theme to phptemplate
I was not able to change some things that they look the way you know it from the current theme
changes compared with the current theme:
* t("By %author at %date") was removed and no there is the default-text
why? because i think it is not in the pot-file, it is not used in another theme and it is better to stay as consistent as possible
* $submitted and $links are not passed through theme_link together... (veeery small change)
I was not able to disable the unsupported "toggle"-features.
the function which should do this is in the chameleon.theme so maybe anyone else has a idea
I read somewhere that it is not possible to attach in a patch-file newly created files.
I dont want to try it myself now so i upload one file after another...
Comment | File | Size | Author |
---|---|---|---|
#4 | template.php.txt | 142 bytes | Tobias Maier |
#3 | page.tpl.php_0.txt | 1.9 KB | Tobias Maier |
#2 | node.tpl.php.txt | 375 bytes | Tobias Maier |
#1 | comment.tpl.php.txt | 252 bytes | Tobias Maier |
chameleon.theme | 252 bytes | Tobias Maier |
Comments
Comment #1
Tobias Maier CreditAttribution: Tobias Maier commentedComment #2
Tobias Maier CreditAttribution: Tobias Maier commentedComment #3
Tobias Maier CreditAttribution: Tobias Maier commentedComment #4
Tobias Maier CreditAttribution: Tobias Maier commentedComment #5
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedI very much like the possibility to not use any theme engine and I am inclined to "won't fix" this.
Comment #6
Tobias Maier CreditAttribution: Tobias Maier commentedbut for what do we have a good theming engine in core?
just for fun?
we should use it in every theme so that it is much easier to change parts or to share customisations (eg. in the template.php - see Include template*.php)
And personaly for me I dont like it that I have to look in the handbook again to see what for possibilities I have with this "*.theme"-themingengine...
I want to use the theming engine which the devs made to the default-theming-engine.
I think this is an inconsistency which needs to be fixed
Comment #7
jvincher CreditAttribution: jvincher commentedFWIW, i've tested this theme with 4.6 and it works like a charm. If not part of the standard Drupal distro, let's at least make the full theme for PHPtemplate downloadable somewhere.
Thanks, Tobias, for your work on this.
Comment #8
Dries CreditAttribution: Dries commentedI suggest you maintain this theme in the contributions repository. Having a PHP theme in core is a good thing, for now. We might revisit this after the Drupal 4.7 release. It's too early to dump all other theme engines.
Comment #9
zuryasse CreditAttribution: zuryasse commentedThanks, I needed this. So can the full theme be downloaded from somewhere? I can't find it.
Comment #10
Tobias Maier CreditAttribution: Tobias Maier commentedI will upload it this week to cvs.
Had no time to do this right now (because of some examns)
Comment #11
bdragon CreditAttribution: bdragon commented