Number of node on archive_page()

patch to add pager functionality to archive_page.

The patch looks good.

It does a drupal_goto() which is kind of annoying, but the archive module uses a POST in order to get the date, and the pager can't really do that. Drupal won't take GET arguments from POST either. And the pager won't take an alternative URL, even though it will allow you to pass through a series of variables to pass through to the URL. And that'd require a little more code to parse those.

I'm ok with the drupal_goto() until pager can be changed to allow alternative URL.

+1

Can we put some thought/effort in eliminating the drupal_goto()?

The prior solutions I thought of were using $_SESSION to store the selection state, converting the form to use _GET, or adding an alternative URL to theme_pager, or passing the date info as a query string to archive page.

The get and querystring options break the nice clean URL's when using the date selector.

Adding an alternative URL to theme_pager means changing something in core for a single use case, which doesn't seem prudent, unless there is use for this functionality else where (other forms using post selectors and theme_pager may have a user for it).

Using SESSION is easiest and quickest, but its a session variable that will only be used for the archive_page and does nothing else most of the time, breaks clean urls for deep linking, but does bring you back to the same location when you return to the archive page.

The may be some form api wizardry that can do the job that I am not aware of.

The important part is the date selection must persist along side the pager data.

I'm not sure what would be the best route... Would appreciate an opinion on which direction to concentrate my effort.

not critical.

I am considering this as a short term bugfix for 4.7.

It seems like the formapi changes have removed the POST-only behavior and the URLs always have the date anyway. I think this means we can throw out the drupal_goto() part.

Unless it was very recently changed, I can say with some assurance that forms API doesn't get along well with using get args. You can tell it to use get as the method, but annoyingly it will not read form values from $_GET.

I've wanted to apply it to 4.7 but it doesn't apply to it anymore.

This is relevant for the 4.7.x branch, if updated. Please update the patch.

Patch for 4.7.4. Removed drupal_goto(). The rest remains unchanged. After patch, archive page has pager function.

applied