Because right now it only shows the sum, it would be great if it is also possible to see the total up and down votes.
I tried to look for this option, but didn't manage to make it happen.

Any tips?

CommentFileSizeAuthor
#4 up_down.patch2.86 KBmunikho

Comments

munikho’s picture

munikho commented
Status: Active » Fixed

After refreshing my math skills and editing the module a bit, i discovered how to calculate the total up and total down votes.
Would there be interest in merging this in the module?

lourenzo’s picture

lourenzo commented

That would be a great addition, IMO.

Would you send a patch here?

Thanks,

--
Lourenzo Ferreira

fanta’s picture

fanta commented

seconded :)
was just looking for this feature, so please post

munikho’s picture

munikho commented
StatusFileSize
new up_down.patch2.86 KB

Well, i'll apply a patch here, but it is no way of being finished. At the moment it's only modified for the extra_voting_forms karma_3. So some work would need to be done to add the other ones as well (but that's not so difficult)

Hope it works for you.

lourenzo’s picture

lourenzo commented
Component: User interface » Code
Assigned: Unassigned » lourenzo
Status: Fixed » Active
lourenzo’s picture

lourenzo commented
Status: Active » Needs review
lourenzo’s picture

lourenzo commented
Status: Needs review » Needs work

thanks, @munikho

I'm managing to merge this code to the module, ASAP.

munikho’s picture

munikho commented

Your welcome.

fanta’s picture

fanta commented

thanks for posting
though have had a few probs
tried patching
but get
patch: **** unexpected end of file in patch

tried doing it by hand but get a error

Fatal error: Cannot redeclare theme_extra_voting_forms_3()

any pointers

WildBill’s picture

WildBill commented

subscribe

mercmobily’s picture

mercmobily commented
Status: Needs work » Fixed

Hi,

Guys, I am not so convinced about this patch.
The main issue I have is that it changes the number of parameters to function theme_extra_voting_forms_X() which will break things.

Also, I am not convinced it's something that should live in the main module, since it's such a fringe feature. One extra query PER FORM for something that 0.1% of users will use... I think this shuld be left to the template makers (which is what's happening now).

Marking it as fixed.

Merc.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

aac’s picture

aac commented

Subscribing!!