I'm starting to work on several patches for the queue here, and I'd like to take care of any coder warnings and trailing whitespace that my IDE always auto-fixes so I don't pick them up in every patch I create.

CommentFileSizeAuthor
#1 410306-mollom-coder-D6.patch13.79 KBdave reid
#1 410306-mollom-coder-D5.patch36.82 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 410306-mollom-coder-D5.patch36.82 KB
new 410306-mollom-coder-D6.patch13.79 KB

Patches attached for 6.x and 5.x branches. No code functionality changes.

Freso’s picture

Freso commented
Status: Needs review » Needs work

Mostly looks good. Has a few glitches though:

     $data = array(
       'post_title' => $comment->subject,
-      'post_body'  => $comment->comment,
+      'post_body' => $comment->comment,
     );

The old one with "[space][space]=>" is actually valid (see "Function Calls" of the Coding standards). If Coder complains about this, a bug should be filed there.

There's also some more clean-up that could be done... I'll see about re-rolling.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

In the case on the patch, just having two lines should not warrant linking up the assignment operators and it looks silly. That's why I also didn't change any of the aligned assignment operators that had 4 or more lines.

dries’s picture

dries commented

Committed to DRUPAL-6.

The patch for D5 failed to apply, but that is probably OK -- I'm a lot less worried about the D5 version of the module. Only bother to re-roll the D5 patch when it is fast/easy. Thanks!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 6.x-1.x-dev » 5.x-1.7
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Fixed

Fixed in CVS for Drupal 5.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.