if no 'access statistics' permission, don't show stats @ node [#41034]

under each node, we render a number of views or that node. IF a user does not have "access statistics" we should not show this.

Patch fixes that. its a small one-liner.

Comment	File	Size	Author
	stqts_lost_perm_check.diff	954 bytes	Bèr Kessels

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rkerr CreditAttribution: rkerr commented 13 December 2005 at 16:53

Seems to make sense... :)

Comment #2

jvandyk CreditAttribution: jvandyk commented 13 December 2005 at 17:42

Yes, this is good. Current behavior is a bug and this patch fixes it.

But I'd rather see a new permission 'access view counts' or some such so that I can turn on view counts without having to give full statistics access to that role.

Comment #3

Bèr Kessels CreditAttribution: Bèr Kessels commented 13 December 2005 at 19:05

Thinking about it a bit more.
* any $link[] can now be filtered. thus this patch is not at all needed to get the same result: just a theme function that strips out the count 'link' should do.
* any themer can add $count data . so *not* showing this at all by default makes sense too.

I guess its al about what we want as default behaviour.

My vote goes to:
Apply this patch. Then anyone who wants to show anyone the node-view count can do so in a theme function.

But Im perfectly fine if people decide to:
Won't fix this patch and let me+others, who do not want to show this to users, 'hack' it out in a rather simple theme function.

But I am not for a separate permission for this. its not really a permission. And if we go for an option/permission, it should live in the "admin > settings > content-types" and be a per-node option, imnsho.

Comment #4

Bèr Kessels CreditAttribution: Bèr Kessels commented 13 December 2005 at 19:08

forgot: that last option might be the best. but i'm not coding it :p
Though imho it should just be as simple as a nodapi thing that adds a $node->viewcount. or even $node->viewcount->daily $node->viewcount->alltime. That would be soooo usefull :)