Download & Extend

Improve 'Textual comparison' condition

Project:Rules
Version:6.x-1.x-dev
Component:User interface
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Usability

Issue Summary

This condition is hard for people to understand and use, so I think we should add more explanation and help. I spent a little bit of time looking at other text comparison UI's, but nowhere near what I think is necessary to make the interface what it could be.

Some initial ideas.
- Left to right might be a better direction than up to down.
- We could improve the text fields with labels and make them expandable as well.
- We should definitely add a link to Online Regular Expression Builder.

More to come.

Comments

#1

Are all of the regular expressions allowed in the Online Regular Expression Builder allowed? I'd love to have a negative look-behind (?<!....) but I wasn't sure how common that was outside of Perl...

#2

@Mitchell,
Maybe you can create a patch that adds a link to the Wikipedia definition - you can look at the flag integration, it has a link to the singelton definition.

#3

oh, fine.

>- Left to right might be a better direction than up to down.
Do you meaning putting the textfields on the same line? I think having the whole line is good when comparing longer strings?

>- We could improve the text fields with labels and make them expandable as well.
We would have to change them to textareas I think. Why not, perhaps just add only a few rows by default, 2 or 3?

>- We should definitely add a link to Online Regular Expression Builder.
That sounds to be a fine idea, however we need to check that generated regexes are working fine.. (as #1 says)

#4

Status:active» needs review

@1: Not sure about all, but I've used this regex builder several times and it worked. Please give it a try.

@2: That was helpful, thanks.

@left to right & textareas: I'll keep messing around to try and find a good layout.

AttachmentSizeStatusTest resultOperations
regex.patch905 bytesIgnored: Check issue status.NoneNone

#5

tag

#6

Status:needs review» fixed

patch committed, thanks.

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.