Posted by markus_petrux on December 13, 2005 at 7:50pm
Jump to:
| Project: | Browscap |
| Version: | master |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | deekayen |
| Status: | closed (fixed) |
Issue Summary
First, thanks for this module, really useful.
I just made a little modification to make it work for drupal 4.7. It only affected the function browscap_settings(). Here's the one that seems to work:
function browscap_settings() {
// Restrict administration of this module
if (!user_access('administer browscap')) {
return message_access();
}
$fileversion = variable_get('browscap_version', 'Never fetched');
$form = array(
'browscap_version' => array(
'#type' => 'markup',
'#value' => t('<p>Browscap data current as of %fileversion</p>', array('%fileversion'=>$fileversion))
)
);
$monitor = variable_get('browscap_monitor', FALSE);
$form['browscap_monitor'] = array(
'#type' => 'checkbox',
'#title' => t('Monitor browsers'),
'#default_value' => $monitor,
'#description' => t('Monitor all user agents visiting the site.')
);
return $form;
}Hope that helps
Comments
#1
#2
I'm working on a new module integrating browscap/statistics_filter/statistics_trends and don't plan on updating the individual modules to 4.7. Although it appears deekayen has volunteered to take on browscap...
#3
I use browscap, statistics_filter, and statistics_trends, so that is good news.
To clarify, I don't plan on taking over browscap. I just want to be able to upgrade to 4.7 as soon as it is stable, so I wanted to make sure this patch made it into CVS so I could upgrade.
#4
Committed and branched for DRUPAL-4-7.