Posted by tomws on March 23, 2009 at 9:55pm
| Project: | Guestbook |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
As the title says, the Cancel link on the Delete entry confirmation page incorrectly points to http://guestbook/
Comments
#1
This is also a problem for the other administrative links on the guestbook entries. It's a problem with the way the links are built manually in the code. Using the drupal_get_destination() function seems to fix this. Patch attached.
Also attached in a patch that can be applied a version that has my pre-publish moderation patch already applied.
#2
Bad title change last time. It's not the links, but the destinations that are flawed. For example, they come out as
http://example.com/guestbook/delete/1?destination=/guestbookor
http://example.com/?q=guestbook/delete/1&destination=/?q=guestbookWhen propagated to the confirmation handler, that translates to a final destination http://guestbook.
The patch still works, but my description was miserable. Apologies, and hope this helps.
#3
I had this same issue and it's even more compounded when the installation is in a subdirectory. I have re-run the patch against the latest 6.x-2.x-dev 2010-04-03. I added the pager string back in since it was missing from the patches in #1.
#4
Thanks for reporting, reviewing, and testing! Committed to HEAD.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.