As the title says, the Cancel link on the Delete entry confirmation page incorrectly points to http://guestbook/

CommentFileSizeAuthor
#3 guestbook-411486-moderate-links-destination-6.x-2.x-dev-20100403.patch1.15 KBrecrit
#1 guestbook-fix_admin_link_destinations.patch1.13 KBtomws
#1 guestbook-fix_admin_link_destinations-for_prepublish_patched.patch1.45 KBtomws

Comments

tomws’s picture

tomws commented
Title: Delete "Cancel" link points to http://guestbook/ » Administration links on entries point to http://guestbook/
Status: Active » Needs review
StatusFileSize
new guestbook-fix_admin_link_destinations-for_prepublish_patched.patch1.45 KB
new guestbook-fix_admin_link_destinations.patch1.13 KB

This is also a problem for the other administrative links on the guestbook entries. It's a problem with the way the links are built manually in the code. Using the drupal_get_destination() function seems to fix this. Patch attached.

Also attached in a patch that can be applied a version that has my pre-publish moderation patch already applied.

tomws’s picture

tomws commented
Title: Administration links on entries point to http://guestbook/ » Incorrect destination on administration links

Bad title change last time. It's not the links, but the destinations that are flawed. For example, they come out as

http://example.com/guestbook/delete/1?destination=/guestbook
or
http://example.com/?q=guestbook/delete/1&destination=/?q=guestbook

When propagated to the confirmation handler, that translates to a final destination http://guestbook.

The patch still works, but my description was miserable. Apologies, and hope this helps.

recrit’s picture

recrit commented
StatusFileSize
new guestbook-411486-moderate-links-destination-6.x-2.x-dev-20100403.patch1.15 KB

I had this same issue and it's even more compounded when the installation is in a subdirectory. I have re-run the patch against the latest 6.x-2.x-dev 2010-04-03. I added the pager string back in since it was missing from the patches in #1.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Thanks for reporting, reviewing, and testing! Committed to HEAD.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.