Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The form generated when only one format is available hasn't been correctly updated from D6 :
$form[$format->format] = array('#type' => 'value', '#value' => $format->format, '#parents' => $parents);
This was OK in D6, when the format selectors were separate '#type' = 'radio' form elements keyed by $format->format (http://api.drupal.org/api/function/filter_form/6)
It does not match the D7 structure, where the format selector is a select (http://api.drupal.org/api/function/filter_form/7)
The line above should be :
$form['format'] = array('#type' => 'value', '#value' => $format->format, '#parents' => $parents);
| Comment | File | Size | Author |
|---|---|---|---|
| fix_filter_format.patch | 1.59 KB | yched |
Comments
Comment #1
catchThis doesn't seem to be breaking anything obvious at the moment - is it causing issues with another patch? Worth writing a test for?
Comment #2
yched commentedI encountered this when working on #375907: Make text field use D7 '#text_format' selector. If / when #412016: Custom key name for #text_format. gets fixed, then the former shouldn't hit the bug anymore.
Other than that, it in fact doesn't break anything obvious right now, so I'm not sure what to write a test against.
More a matter of consistency between the 'multiple formats available' and 'only one format available' code branches. In the end, it does currently produce similar $form_state['values'] structure, but It could however make odd behaviors pop up later.
Comparing the D6 and D7 versions of filter_form() make it pretty clear that the last code branch was not updated to match the generic case, so I think we should fix this anyway.
Comment #3
David_Rothstein commentedYeah, this seems like a no-brainer and a simple fix. In fact, it was noted a while ago in #304330: Text format widget, just never included in the final patch that was committed there.
Comment #4
sunSorry, but it makes no sense to fix the mess in countless other issues.