restructure theme_image_attach_body/teaser

I'm baffled, as the only thing that depends on the node type is this line:
$img_size = variable_get('image_attach_size_body_'. $node->type, IMAGE_THUMBNAIL);

Can you output that to see what you're getting?

Obviously you're getting weird things... the variable image_attach_size_body_TYPE is for full body.
For each node type, there are two variables:
- image_attach_size_body_TYPE
- image_attach_size_teaser_TYPE

When you say 'teaser view' -- are you using Views module, or do you mean just a Drupal core list of node teasers such as the front page?

We need to figure out which of theme_image_attach_teaser and theme_image_attach_body is getting called when the problem occurs -- each one respectively checks its appropriate variable. Can you find that out please? Stick as dsm('theme_image_attach_body') in one and likewise for the other. If it's the wrong one, can you do a backtrace?

_TYPE is the node type. eg 'story'.
dsm is a function in devel module. It's useful.

So you're saying that:
- case 1: if you add your own call to print theme_image_attach_body in the node template, you get the image you're printing yourself AND the one image prints,
- case 2: if you set the image attach display options for that content type to hidden, you get neither.

If you look at the code of theme_image_attach_body/teaser, you'll see it checks image size, and if image size is hidden, it shows nothing.
So all is working as the code is written.

However, this is not ideal.
Surely, if you hide the image, it's because you want to handle theming yourself -- as you're trying to do.

The split between logic and theming isn't good either -- for starters, this has no place in a theming function:

    $image = node_load($node->iid);

We need a function that comes before this, that handles loading the image node etc.
The question would remain of where to find the size required and where best for custom use to call in.

Marking #221608: better theming split: can't get to IMG tag or image URL in templates as a duplicate.

A note from there:

The plain URL of the image should be loaded:

        $node->content['image_attach'] = array(
          '#value' => theme("image_attach_{$teaser_or_body}", $node),
          '#weight' => variable_get("image_attach_weight_{$teaser_or_body}_{$node->type}", 0),

This has to wait for #81102: Attach Multiple Images with image_attach using Drupal upload mechanism.

However, in the meantime, here's what I propose for the theme functions:

- nodeapi: view should take care of node_load() on all of the iids, and also the node_access checks. (strictly speaking this should be done on load op, but then we're carrying around potentially heaps of node objects to the next call -- is that a bad thing?). We also check IMAGE_ATTACH_HIDDEN the current content type options.
- this calls a wrapper theme function with an array of the image data: theme_image_attach($nid, $image_nodes)
- this in turn calls a theme function for each individual image.

Opened again.

Here's a patch.

I've gone for just one theming function -- the teaser/body versions were almost identical apart from where the link goes. If users want to specialize, they can switch on $teaser.
As for theming each image individually, I decided that was overkill. image_display gets called, which calls theme_image_display() so that's available too.

Once this is fixed, #698284: Reverse attached image thumbnails so they are in the correct order left to right can be looked at.

Waking up the all-new contrib test bot! :)

Needs a reroll.

No reviews after several months.

Here is a reroll which I intend to commit fairly soon.

No reviews in 6 months :( but passes tests -- committed.

#412288 by joachim: Changed structure of theming functions for attached images.

Revisiting this in light of #825130: Image attach field in views shows only last attached image per node.

I don't want to hijack the node theme function for Views output, so I'm refactoring this so we have a general theme function that both the node and block theme functions call.

The Views handler can then call this too -- patch for that will be at #825130: Image attach field in views shows only last attached image per node.

Argh PHP. Why can't you be more like Perl?

Sad panda has no patch reviews but commits this anyway with an increasing cavalier attitude ;)

#412288 by joachim: (Continued) Changed structure of theming functions for attached images, this time with Views support.

+    if (!isset($div_attributes['style'])) {
+      $div_attributes['style'] = '';
+    }
+    $div_attributes['style'] .= 'width: ' . $info['width'] . 'px;';

This hard-coded style makes the default theme not usable if you want to show the pics with different dimension. For example, the thumbnail width is 200px, but in some places in the layout it should be 180px or 160px.

> For example, the thumbnail width is 200px, but in some places in the layout it should be 180px or 160px.

Then you need more derivatives...

In general, please open new bug reports for a follow-on such as this.