When I re-edit a node with an image I've previously cropped, I can see the outlines of crop window overlayed on the image, but it's a different shape and position than where the image is currently cropped. It doesn't change anything straight away -- if I save the node without touching the crop widget, the image stays the same -- but I think the end-user will wonder if she has to fix the cropping every time she edits the node since it looks like it's out of place.

Tested on a Mac using FF3.07, Safari 3 and IE7 in a virtual XP environment. In IE6 it doesn't show try to show my the previously cropped window at all, which is almost preferable.

Comments

les lim’s picture

les lim
he/they
Primary language English
commented
Title: crop window is positioned differently on re-edit » crop selection position/size changes on revisiting node edit form

Some more information: this is only happening for me if the crop selection is saved when it's flush against either the top or the left side of the image. If it is, then the top, left, width and height attributes of the crop window are each multiplied by 1.5 the next time I visit the node edit form.

And I was mistaken about IE6; it does show me the previous crop selection, and the same thing is happening for it as with the other browsers.

johnmunro’s picture

johnmunro commented

Yes, I am seeing the same behaviour in FF3 on XP

yhager’s picture

yhager commented
Status: Active » Fixed

Using your detailed description, I managed to hunt this down and fix it. The fix will be in the next release, or in the development version until then.

Thank you for the report.

johnmunro’s picture

johnmunro commented

Confirmed fixed in dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

moritzz’s picture

moritzz commented
Status: Closed (fixed) » Active

For me this is still an issue with the latest dev release (2009-Jun-18) and the Safari 4 Final or Firefox 3.0.11. It happens with any cropping applied. Fortunately saving the node keeps the original area intact. Any hints?

moritzz’s picture

moritzz commented
Version: 6.x-1.0-beta3 » 6.x-1.x-dev
yhager’s picture

yhager commented
Assigned: Unassigned » yhager

@omo: could it be that it happens only on images that are larger than the crop area? Latest Jcrop (which exists in the latest dev) added internal calculation for this situation, while imagefield_crop tries to handle it by itself, leading to a duplicate (erronous) calculation.

yhager’s picture

yhager commented
Status: Active » Fixed

Fix committed.

moritzz’s picture

moritzz commented

@yhager

Mhm, you're probably right. My settings are:

The resolution to crop the image onto:
640x440

The resolution of the cropping area:
500x500

And max. image resolution of the image field ist set to 960x960.

I quickly check the dev from 2009-Mar-19 and let you know.

Thanks a lot for the great work: This module is a real time safer.

moritzz’s picture

moritzz commented

I can commit! Works flawlessly now. Thanks a lot.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

doublejosh’s picture

doublejosh commented

Still getting this problem in Chrome (3.0.195), FireFox (3.5.3), Safari (4.0.3) and IE (7.0.5730) on a PC.

It does not save the weird crop change, but displays it different than it was left.

.info says: v 1.1.4.2 2009/02/06 06:01:41