Summary

Site admin is unable to delete just one file, using the uc_file module.

Steps to reproduce

- Go to the main list of downloadable files at admin/store/products/files.
- Upload several files.
- Select one uploaded file.
- Select "Delete file(s)" under Action, and click the "Perform action" button.

Expected Result

- The confirmation page should list only the files that were selected.
- Clicking the "Delete affected files" button should delete only those selected (then listed) files.

Actual Result

- The confirmation page lists *all* files that were listed on the previous page.
- Clicking the "Delete affected files" button deletes *all* files that were listed on the previous page.

I would also like to make a couple of suggestions regarding user interface, since they seem to fit into this same work area.

Deleting

- have a "delete" button at the top of the list, as its own independent button.

Uploading

- have a link that takes you to a "Upload file" page. Or better yet, include the file upload form at the top of the file listing page.

These would replace the dropdown menu that currently defaults to "Delete file(s)."

I would not mind digging in and making these updates myself. But since I am new to Ubercart development, I would like to gather some feedback from other Ubercart developers first. What do you think about these changes? If I implemented these cleanly, would my patch be accepted?

Looking forward to contributing!
-david

CommentFileSizeAuthor
#1 412372.value_check.2.x.patch467 bytescha0s

Comments

cha0s’s picture

Assigned: Unassigned » cha0s
Status: Active » Needs review
StatusFileSize
new467 bytes

Wow, good find... here's a patch that should cure it (let me know). Thanks!

EDIT: Just noticed your suggestions. If you want to, you can create another feature request issue about this, and feel free to submit a patch with the changes. I always thought that part of the file UI was weird, but I did more refactoring than ground up rebuilding.

nadavoid’s picture

Status: Needs review » Reviewed & tested by the community

The patch works! Thanks so much.

I will probably open a feature request for the things I was suggesting.

Thanks again for the quick patch!

Island Usurper’s picture

Status: Reviewed & tested by the community » Fixed

Cool. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.